Commit 222bce5e authored by Nicholas Mc Guire's avatar Nicholas Mc Guire Committed by Takashi Iwai

ALSA: snd-aoa: add of_node_put() in error path

 Both calls to of_find_node_by_name() and of_get_next_child() return a
node pointer with refcount incremented thus it must be explicidly
decremented here after the last usage. As we are assured to have a
refcounted  np  either from the initial
of_find_node_by_name(NULL, name); or from the of_get_next_child(gpio, np)
in the while loop if we reached the error code path below, an
x of_node_put(np) is needed.
Signed-off-by: default avatarNicholas Mc Guire <hofrat@osadl.org>
Fixes: commit f3d9478b ("[ALSA] snd-aoa: add snd-aoa")
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent fdd49c51
...@@ -88,8 +88,10 @@ static struct device_node *get_gpio(char *name, ...@@ -88,8 +88,10 @@ static struct device_node *get_gpio(char *name,
} }
reg = of_get_property(np, "reg", NULL); reg = of_get_property(np, "reg", NULL);
if (!reg) if (!reg) {
of_node_put(np);
return NULL; return NULL;
}
*gpioptr = *reg; *gpioptr = *reg;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment