Commit 223153ea authored by Yang Yingliang's avatar Yang Yingliang Committed by David S. Miller

net: ethernet: sunplus: add missing of_node_put() in spl2sw_mdio_init()

of_get_child_by_name() returns device node pointer with refcount
incremented. The refcount should be decremented before returning
from spl2sw_mdio_init().

Fixes: fd3040b9 ("net: ethernet: Add driver for Sunplus SP7021")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Reviewed-by: default avatarWells Lu <wellslutw@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7ba106fc
...@@ -97,8 +97,10 @@ u32 spl2sw_mdio_init(struct spl2sw_common *comm) ...@@ -97,8 +97,10 @@ u32 spl2sw_mdio_init(struct spl2sw_common *comm)
/* Allocate and register mdio bus. */ /* Allocate and register mdio bus. */
mii_bus = devm_mdiobus_alloc(&comm->pdev->dev); mii_bus = devm_mdiobus_alloc(&comm->pdev->dev);
if (!mii_bus) if (!mii_bus) {
return -ENOMEM; ret = -ENOMEM;
goto out;
}
mii_bus->name = "sunplus_mii_bus"; mii_bus->name = "sunplus_mii_bus";
mii_bus->parent = &comm->pdev->dev; mii_bus->parent = &comm->pdev->dev;
...@@ -110,10 +112,13 @@ u32 spl2sw_mdio_init(struct spl2sw_common *comm) ...@@ -110,10 +112,13 @@ u32 spl2sw_mdio_init(struct spl2sw_common *comm)
ret = of_mdiobus_register(mii_bus, mdio_np); ret = of_mdiobus_register(mii_bus, mdio_np);
if (ret) { if (ret) {
dev_err(&comm->pdev->dev, "Failed to register mdiobus!\n"); dev_err(&comm->pdev->dev, "Failed to register mdiobus!\n");
return ret; goto out;
} }
comm->mii_bus = mii_bus; comm->mii_bus = mii_bus;
out:
of_node_put(mdio_np);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment