Commit 227686b6 authored by Ioana Radulescu's avatar Ioana Radulescu Committed by Greg Kroah-Hartman

staging: fsl-dpaa2/eth: Update default hash key

In our documentation, we claim to use a 5-tuple key for Rx hash
distribution of flows. The code however configures a key composed
of all supported header fields.

Update the Rx hash key to contain only the documented fields:
{IP src, IP dst, IP nextproto, L4 src, L4 dst}, which was the
original intention and makes most sense as a default.
Signed-off-by: default avatarIoana Radulescu <ruxandra.radulescu@nxp.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ff5c3798
...@@ -2195,10 +2195,10 @@ static int bind_dpni(struct dpaa2_eth_priv *priv) ...@@ -2195,10 +2195,10 @@ static int bind_dpni(struct dpaa2_eth_priv *priv)
return err; return err;
} }
/* have the interface implicitly distribute traffic based on supported /* have the interface implicitly distribute traffic based on
* header fields * the default hash key
*/ */
err = dpaa2_eth_set_hash(net_dev, DPAA2_RXH_SUPPORTED); err = dpaa2_eth_set_hash(net_dev, DPAA2_RXH_DEFAULT);
if (err) if (err)
dev_err(dev, "Failed to configure hashing\n"); dev_err(dev, "Failed to configure hashing\n");
......
...@@ -377,11 +377,14 @@ struct dpaa2_eth_priv { ...@@ -377,11 +377,14 @@ struct dpaa2_eth_priv {
u64 rx_hash_fields; u64 rx_hash_fields;
}; };
/* default Rx hash options, set during probing */
#define DPAA2_RXH_SUPPORTED (RXH_L2DA | RXH_VLAN | RXH_L3_PROTO \ #define DPAA2_RXH_SUPPORTED (RXH_L2DA | RXH_VLAN | RXH_L3_PROTO \
| RXH_IP_SRC | RXH_IP_DST | RXH_L4_B_0_1 \ | RXH_IP_SRC | RXH_IP_DST | RXH_L4_B_0_1 \
| RXH_L4_B_2_3) | RXH_L4_B_2_3)
/* default Rx hash options, set during probing */
#define DPAA2_RXH_DEFAULT (RXH_L3_PROTO | RXH_IP_SRC | RXH_IP_DST | \
RXH_L4_B_0_1 | RXH_L4_B_2_3)
#define dpaa2_eth_hash_enabled(priv) \ #define dpaa2_eth_hash_enabled(priv) \
((priv)->dpni_attrs.num_queues > 1) ((priv)->dpni_attrs.num_queues > 1)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment