Commit 22843255 authored by Jason Wang's avatar Jason Wang Committed by Michael S. Tsirkin

virtio-rng: make device ready before making request

Current virtio-rng does a entropy request before DRIVER_OK, this
violates the spec:

virtio spec requires that all drivers set DRIVER_OK
before using devices.

Further, kernel will ignore the interrupt after commit
8b4ec69d ("virtio: harden vring IRQ").

Fixing this by making device ready before the request.

Cc: stable@vger.kernel.org
Fixes: 8b4ec69d ("virtio: harden vring IRQ")
Fixes: f7f510ec ("virtio: An entropy device, as suggested by hpa.")
Reported-and-tested-by: syzbot+5b59d6d459306a556f54@syzkaller.appspotmail.com
Signed-off-by: default avatarJason Wang <jasowang@redhat.com>
Message-Id: <20220608061422.38437-1-jasowang@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Reviewed-by: default avatarLaurent Vivier <lvivier@redhat.com>
parent f2906aa8
...@@ -159,6 +159,8 @@ static int probe_common(struct virtio_device *vdev) ...@@ -159,6 +159,8 @@ static int probe_common(struct virtio_device *vdev)
goto err_find; goto err_find;
} }
virtio_device_ready(vdev);
/* we always have a pending entropy request */ /* we always have a pending entropy request */
request_entropy(vi); request_entropy(vi);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment