Commit 22bc22cc authored by renjun wang's avatar renjun wang Committed by Thomas Zimmermann

drm: Fix kerneldoc for "Returns" section

The blank line between title "Returns:" and detail description is not
allowed, otherwise the title will goes under the description block in
generated .html file after running `make htmldocs`.

There are a few examples for current kerneldoc at [1][2][3].

v2:
- use Link tag with stable URLs
Signed-off-by: default avatarrenjun wang <renjunw0@foxmail.com>
Link: https://www.kernel.org/doc/html/v6.10/gpu/drm-kms.html#c.drm_crtc_commit_wait # 1
Link: https://www.kernel.org/doc/html/v6.10/gpu/drm-kms.html#c.drm_atomic_get_crtc_state # 2
Link: https://www.kernel.org/doc/html/v6.10/gpu/i915.html#c.i915_vma_pin_fence # 3
Reviewed-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/tencent_37A873672B5CD20DECAF99DEDAC5E45C3106@qq.com
parent cf4d37b8
...@@ -5569,7 +5569,6 @@ EXPORT_SYMBOL(drm_dp_mst_atomic_check_mgr); ...@@ -5569,7 +5569,6 @@ EXPORT_SYMBOL(drm_dp_mst_atomic_check_mgr);
* drm_dp_atomic_release_time_slots() * drm_dp_atomic_release_time_slots()
* *
* Returns: * Returns:
*
* 0 if the new state is valid, negative error code otherwise. * 0 if the new state is valid, negative error code otherwise.
*/ */
int drm_dp_mst_atomic_check(struct drm_atomic_state *state) int drm_dp_mst_atomic_check(struct drm_atomic_state *state)
...@@ -5606,7 +5605,6 @@ EXPORT_SYMBOL(drm_dp_mst_topology_state_funcs); ...@@ -5606,7 +5605,6 @@ EXPORT_SYMBOL(drm_dp_mst_topology_state_funcs);
* topology object. * topology object.
* *
* RETURNS: * RETURNS:
*
* The MST topology state or error pointer. * The MST topology state or error pointer.
*/ */
struct drm_dp_mst_topology_state *drm_atomic_get_mst_topology_state(struct drm_atomic_state *state, struct drm_dp_mst_topology_state *drm_atomic_get_mst_topology_state(struct drm_atomic_state *state,
...@@ -5626,7 +5624,6 @@ EXPORT_SYMBOL(drm_atomic_get_mst_topology_state); ...@@ -5626,7 +5624,6 @@ EXPORT_SYMBOL(drm_atomic_get_mst_topology_state);
* topology object. * topology object.
* *
* Returns: * Returns:
*
* The old MST topology state, or NULL if there's no topology state for this MST mgr * The old MST topology state, or NULL if there's no topology state for this MST mgr
* in the global atomic state * in the global atomic state
*/ */
...@@ -5651,7 +5648,6 @@ EXPORT_SYMBOL(drm_atomic_get_old_mst_topology_state); ...@@ -5651,7 +5648,6 @@ EXPORT_SYMBOL(drm_atomic_get_old_mst_topology_state);
* topology object. * topology object.
* *
* Returns: * Returns:
*
* The new MST topology state, or NULL if there's no topology state for this MST mgr * The new MST topology state, or NULL if there's no topology state for this MST mgr
* in the global atomic state * in the global atomic state
*/ */
......
...@@ -63,7 +63,6 @@ EXPORT_SYMBOL(__drm_crtc_commit_free); ...@@ -63,7 +63,6 @@ EXPORT_SYMBOL(__drm_crtc_commit_free);
* hardware and flipped to. * hardware and flipped to.
* *
* Returns: * Returns:
*
* 0 on success, a negative error code otherwise. * 0 on success, a negative error code otherwise.
*/ */
int drm_crtc_commit_wait(struct drm_crtc_commit *commit) int drm_crtc_commit_wait(struct drm_crtc_commit *commit)
...@@ -337,7 +336,6 @@ EXPORT_SYMBOL(__drm_atomic_state_free); ...@@ -337,7 +336,6 @@ EXPORT_SYMBOL(__drm_atomic_state_free);
* not created by userspace through an IOCTL call. * not created by userspace through an IOCTL call.
* *
* Returns: * Returns:
*
* Either the allocated state or the error code encoded into the pointer. When * Either the allocated state or the error code encoded into the pointer. When
* the error is EDEADLK then the w/w mutex code has detected a deadlock and the * the error is EDEADLK then the w/w mutex code has detected a deadlock and the
* entire atomic sequence must be restarted. All other errors are fatal. * entire atomic sequence must be restarted. All other errors are fatal.
...@@ -518,7 +516,6 @@ static int drm_atomic_connector_check(struct drm_connector *connector, ...@@ -518,7 +516,6 @@ static int drm_atomic_connector_check(struct drm_connector *connector,
* is consistent. * is consistent.
* *
* Returns: * Returns:
*
* Either the allocated state or the error code encoded into the pointer. When * Either the allocated state or the error code encoded into the pointer. When
* the error is EDEADLK then the w/w mutex code has detected a deadlock and the * the error is EDEADLK then the w/w mutex code has detected a deadlock and the
* entire atomic sequence must be restarted. All other errors are fatal. * entire atomic sequence must be restarted. All other errors are fatal.
...@@ -828,7 +825,6 @@ EXPORT_SYMBOL(drm_atomic_private_obj_fini); ...@@ -828,7 +825,6 @@ EXPORT_SYMBOL(drm_atomic_private_obj_fini);
* object lock to make sure that the state is consistent. * object lock to make sure that the state is consistent.
* *
* RETURNS: * RETURNS:
*
* Either the allocated state or the error code encoded into a pointer. * Either the allocated state or the error code encoded into a pointer.
*/ */
struct drm_private_state * struct drm_private_state *
...@@ -1061,7 +1057,6 @@ EXPORT_SYMBOL(drm_atomic_get_new_crtc_for_encoder); ...@@ -1061,7 +1057,6 @@ EXPORT_SYMBOL(drm_atomic_get_new_crtc_for_encoder);
* make sure that the state is consistent. * make sure that the state is consistent.
* *
* Returns: * Returns:
*
* Either the allocated state or the error code encoded into the pointer. When * Either the allocated state or the error code encoded into the pointer. When
* the error is EDEADLK then the w/w mutex code has detected a deadlock and the * the error is EDEADLK then the w/w mutex code has detected a deadlock and the
* entire atomic sequence must be restarted. All other errors are fatal. * entire atomic sequence must be restarted. All other errors are fatal.
...@@ -1169,7 +1164,6 @@ static void drm_atomic_connector_print_state(struct drm_printer *p, ...@@ -1169,7 +1164,6 @@ static void drm_atomic_connector_print_state(struct drm_printer *p,
* state is consistent. * state is consistent.
* *
* Returns: * Returns:
*
* Either the allocated state or the error code encoded into the pointer. When * Either the allocated state or the error code encoded into the pointer. When
* the error is EDEADLK then the w/w mutex code has detected a deadlock and the * the error is EDEADLK then the w/w mutex code has detected a deadlock and the
* entire atomic sequence must be restarted. * entire atomic sequence must be restarted.
......
...@@ -2266,7 +2266,6 @@ crtc_or_fake_commit(struct drm_atomic_state *state, struct drm_crtc *crtc) ...@@ -2266,7 +2266,6 @@ crtc_or_fake_commit(struct drm_atomic_state *state, struct drm_crtc *crtc)
* automatically. * automatically.
* *
* Returns: * Returns:
*
* 0 on success. -EBUSY when userspace schedules nonblocking commits too fast, * 0 on success. -EBUSY when userspace schedules nonblocking commits too fast,
* -ENOMEM on allocation failures and -EINTR when a signal is pending. * -ENOMEM on allocation failures and -EINTR when a signal is pending.
*/ */
...@@ -3009,7 +3008,6 @@ EXPORT_SYMBOL(drm_atomic_helper_cleanup_planes); ...@@ -3009,7 +3008,6 @@ EXPORT_SYMBOL(drm_atomic_helper_cleanup_planes);
* don't pass the right state structures to the callbacks. * don't pass the right state structures to the callbacks.
* *
* Returns: * Returns:
*
* Returns 0 on success. Can return -ERESTARTSYS when @stall is true and the * Returns 0 on success. Can return -ERESTARTSYS when @stall is true and the
* waiting for the previous commits has been interrupted. * waiting for the previous commits has been interrupted.
*/ */
......
...@@ -347,7 +347,6 @@ int drm_open_helper(struct file *filp, struct drm_minor *minor) ...@@ -347,7 +347,6 @@ int drm_open_helper(struct file *filp, struct drm_minor *minor)
* resources for it. It also calls the &drm_driver.open driver callback. * resources for it. It also calls the &drm_driver.open driver callback.
* *
* RETURNS: * RETURNS:
*
* 0 on success or negative errno value on failure. * 0 on success or negative errno value on failure.
*/ */
int drm_open(struct inode *inode, struct file *filp) int drm_open(struct inode *inode, struct file *filp)
...@@ -406,7 +405,6 @@ static void drm_lastclose(struct drm_device *dev) ...@@ -406,7 +405,6 @@ static void drm_lastclose(struct drm_device *dev)
* in-kernel DRM client. * in-kernel DRM client.
* *
* RETURNS: * RETURNS:
*
* Always succeeds and returns 0. * Always succeeds and returns 0.
*/ */
int drm_release(struct inode *inode, struct file *filp) int drm_release(struct inode *inode, struct file *filp)
...@@ -477,7 +475,6 @@ void drm_file_update_pid(struct drm_file *filp) ...@@ -477,7 +475,6 @@ void drm_file_update_pid(struct drm_file *filp)
* then restores the active in-kernel DRM client. * then restores the active in-kernel DRM client.
* *
* RETURNS: * RETURNS:
*
* Always succeeds and returns 0. * Always succeeds and returns 0.
*/ */
int drm_release_noglobal(struct inode *inode, struct file *filp) int drm_release_noglobal(struct inode *inode, struct file *filp)
...@@ -520,7 +517,6 @@ EXPORT_SYMBOL(drm_release_noglobal); ...@@ -520,7 +517,6 @@ EXPORT_SYMBOL(drm_release_noglobal);
* safety. * safety.
* *
* RETURNS: * RETURNS:
*
* Number of bytes read (always aligned to full events, and can be 0) or a * Number of bytes read (always aligned to full events, and can be 0) or a
* negative error code on failure. * negative error code on failure.
*/ */
...@@ -606,7 +602,6 @@ EXPORT_SYMBOL(drm_read); ...@@ -606,7 +602,6 @@ EXPORT_SYMBOL(drm_read);
* See also drm_read(). * See also drm_read().
* *
* RETURNS: * RETURNS:
*
* Mask of POLL flags indicating the current status of the file. * Mask of POLL flags indicating the current status of the file.
*/ */
__poll_t drm_poll(struct file *filp, struct poll_table_struct *wait) __poll_t drm_poll(struct file *filp, struct poll_table_struct *wait)
...@@ -644,7 +639,6 @@ EXPORT_SYMBOL(drm_poll); ...@@ -644,7 +639,6 @@ EXPORT_SYMBOL(drm_poll);
* already hold &drm_device.event_lock. * already hold &drm_device.event_lock.
* *
* RETURNS: * RETURNS:
*
* 0 on success or a negative error code on failure. * 0 on success or a negative error code on failure.
*/ */
int drm_event_reserve_init_locked(struct drm_device *dev, int drm_event_reserve_init_locked(struct drm_device *dev,
...@@ -686,7 +680,6 @@ EXPORT_SYMBOL(drm_event_reserve_init_locked); ...@@ -686,7 +680,6 @@ EXPORT_SYMBOL(drm_event_reserve_init_locked);
* drm_event_reserve_init_locked() instead. * drm_event_reserve_init_locked() instead.
* *
* RETURNS: * RETURNS:
*
* 0 on success or a negative error code on failure. * 0 on success or a negative error code on failure.
*/ */
int drm_event_reserve_init(struct drm_device *dev, int drm_event_reserve_init(struct drm_device *dev,
......
...@@ -689,7 +689,6 @@ static int objects_lookup(struct drm_file *filp, u32 *handle, int count, ...@@ -689,7 +689,6 @@ static int objects_lookup(struct drm_file *filp, u32 *handle, int count,
* For a single handle lookup, use drm_gem_object_lookup(). * For a single handle lookup, use drm_gem_object_lookup().
* *
* Returns: * Returns:
*
* @objs filled in with GEM object pointers. Returned GEM objects need to be * @objs filled in with GEM object pointers. Returned GEM objects need to be
* released with drm_gem_object_put(). -ENOENT is returned on a lookup * released with drm_gem_object_put(). -ENOENT is returned on a lookup
* failure. 0 is returned on success. * failure. 0 is returned on success.
...@@ -737,12 +736,11 @@ EXPORT_SYMBOL(drm_gem_objects_lookup); ...@@ -737,12 +736,11 @@ EXPORT_SYMBOL(drm_gem_objects_lookup);
* @filp: DRM file private date * @filp: DRM file private date
* @handle: userspace handle * @handle: userspace handle
* *
* Returns: * If looking up an array of handles, use drm_gem_objects_lookup().
* *
* Returns:
* A reference to the object named by the handle if such exists on @filp, NULL * A reference to the object named by the handle if such exists on @filp, NULL
* otherwise. * otherwise.
*
* If looking up an array of handles, use drm_gem_objects_lookup().
*/ */
struct drm_gem_object * struct drm_gem_object *
drm_gem_object_lookup(struct drm_file *filp, u32 handle) drm_gem_object_lookup(struct drm_file *filp, u32 handle)
...@@ -763,7 +761,6 @@ EXPORT_SYMBOL(drm_gem_object_lookup); ...@@ -763,7 +761,6 @@ EXPORT_SYMBOL(drm_gem_object_lookup);
* @timeout: timeout value in jiffies or zero to return immediately * @timeout: timeout value in jiffies or zero to return immediately
* *
* Returns: * Returns:
*
* Returns -ERESTARTSYS if interrupted, 0 if the wait timed out, or * Returns -ERESTARTSYS if interrupted, 0 if the wait timed out, or
* greater than 0 on success. * greater than 0 on success.
*/ */
......
...@@ -539,7 +539,6 @@ static int fill_analog_mode(struct drm_device *dev, ...@@ -539,7 +539,6 @@ static int fill_analog_mode(struct drm_device *dev,
* to reach those resolutions. * to reach those resolutions.
* *
* Returns: * Returns:
*
* A pointer to the mode, allocated with drm_mode_create(). Returns NULL * A pointer to the mode, allocated with drm_mode_create(). Returns NULL
* on error. * on error.
*/ */
......
...@@ -85,7 +85,6 @@ static u32 clip_scaled(int src, int dst, int *clip) ...@@ -85,7 +85,6 @@ static u32 clip_scaled(int src, int dst, int *clip)
* factors from @src to @dst. * factors from @src to @dst.
* *
* RETURNS: * RETURNS:
*
* %true if rectangle @dst is still visible after being clipped, * %true if rectangle @dst is still visible after being clipped,
* %false otherwise. * %false otherwise.
*/ */
......
...@@ -686,7 +686,6 @@ EXPORT_SYMBOL(drm_calc_timestamping_constants); ...@@ -686,7 +686,6 @@ EXPORT_SYMBOL(drm_calc_timestamping_constants);
* drm_atomic_helper_calc_timestamping_constants(). * drm_atomic_helper_calc_timestamping_constants().
* *
* Returns: * Returns:
*
* Returns true on success, and false on failure, i.e. when no accurate * Returns true on success, and false on failure, i.e. when no accurate
* timestamp could be acquired. * timestamp could be acquired.
*/ */
...@@ -831,7 +830,6 @@ EXPORT_SYMBOL(drm_crtc_vblank_helper_get_vblank_timestamp_internal); ...@@ -831,7 +830,6 @@ EXPORT_SYMBOL(drm_crtc_vblank_helper_get_vblank_timestamp_internal);
* drm_atomic_helper_calc_timestamping_constants(). * drm_atomic_helper_calc_timestamping_constants().
* *
* Returns: * Returns:
*
* Returns true on success, and false on failure, i.e. when no accurate * Returns true on success, and false on failure, i.e. when no accurate
* timestamp could be acquired. * timestamp could be acquired.
*/ */
......
...@@ -89,7 +89,6 @@ __i915_gem_object_unset_pages(struct drm_i915_gem_object *obj); ...@@ -89,7 +89,6 @@ __i915_gem_object_unset_pages(struct drm_i915_gem_object *obj);
* @handle: userspace handle * @handle: userspace handle
* *
* Returns: * Returns:
*
* A pointer to the object named by the handle if such exists on @filp, NULL * A pointer to the object named by the handle if such exists on @filp, NULL
* otherwise. This object is only valid whilst under the RCU read lock, and * otherwise. This object is only valid whilst under the RCU read lock, and
* note carefully the object may be in the process of being destroyed. * note carefully the object may be in the process of being destroyed.
......
...@@ -418,7 +418,6 @@ int __i915_vma_pin_fence(struct i915_vma *vma) ...@@ -418,7 +418,6 @@ int __i915_vma_pin_fence(struct i915_vma *vma)
* For an untiled surface, this removes any existing fence. * For an untiled surface, this removes any existing fence.
* *
* Returns: * Returns:
*
* 0 on success, negative error code on failure. * 0 on success, negative error code on failure.
*/ */
int i915_vma_pin_fence(struct i915_vma *vma) int i915_vma_pin_fence(struct i915_vma *vma)
......
...@@ -389,7 +389,6 @@ void i915_vma_unpin_iomap(struct i915_vma *vma); ...@@ -389,7 +389,6 @@ void i915_vma_unpin_iomap(struct i915_vma *vma);
* i915_vma_unpin_fence(). * i915_vma_unpin_fence().
* *
* Returns: * Returns:
*
* True if the vma has a fence, false otherwise. * True if the vma has a fence, false otherwise.
*/ */
int __must_check i915_vma_pin_fence(struct i915_vma *vma); int __must_check i915_vma_pin_fence(struct i915_vma *vma);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment