Commit 23542618 authored by KOVACS Krisztian's avatar KOVACS Krisztian Committed by David S. Miller

inet: Don't lookup the socket if there's a socket attached to the skb

Use the socket cached in the skb if it's present.
Signed-off-by: default avatarKOVACS Krisztian <hidden@sch.bme.hu>
Acked-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 607c4aaf
...@@ -96,10 +96,14 @@ static inline struct sock *__inet6_lookup_skb(struct inet_hashinfo *hashinfo, ...@@ -96,10 +96,14 @@ static inline struct sock *__inet6_lookup_skb(struct inet_hashinfo *hashinfo,
const __be16 sport, const __be16 sport,
const __be16 dport) const __be16 dport)
{ {
return __inet6_lookup(dev_net(skb->dst->dev), hashinfo, struct sock *sk;
&ipv6_hdr(skb)->saddr, sport,
&ipv6_hdr(skb)->daddr, ntohs(dport), if (unlikely(sk = skb_steal_sock(skb)))
inet6_iif(skb)); return sk;
else return __inet6_lookup(dev_net(skb->dst->dev), hashinfo,
&ipv6_hdr(skb)->saddr, sport,
&ipv6_hdr(skb)->daddr, ntohs(dport),
inet6_iif(skb));
} }
extern struct sock *inet6_lookup(struct net *net, struct inet_hashinfo *hashinfo, extern struct sock *inet6_lookup(struct net *net, struct inet_hashinfo *hashinfo,
......
...@@ -378,11 +378,15 @@ static inline struct sock *__inet_lookup_skb(struct inet_hashinfo *hashinfo, ...@@ -378,11 +378,15 @@ static inline struct sock *__inet_lookup_skb(struct inet_hashinfo *hashinfo,
const __be16 sport, const __be16 sport,
const __be16 dport) const __be16 dport)
{ {
struct sock *sk;
const struct iphdr *iph = ip_hdr(skb); const struct iphdr *iph = ip_hdr(skb);
return __inet_lookup(dev_net(skb->dst->dev), hashinfo, if (unlikely(sk = skb_steal_sock(skb)))
iph->saddr, sport, return sk;
iph->daddr, dport, inet_iif(skb)); else
return __inet_lookup(dev_net(skb->dst->dev), hashinfo,
iph->saddr, sport,
iph->daddr, dport, inet_iif(skb));
} }
extern int __inet_hash_connect(struct inet_timewait_death_row *death_row, extern int __inet_hash_connect(struct inet_timewait_death_row *death_row,
......
...@@ -1324,6 +1324,18 @@ static inline void sk_change_net(struct sock *sk, struct net *net) ...@@ -1324,6 +1324,18 @@ static inline void sk_change_net(struct sock *sk, struct net *net)
sock_net_set(sk, hold_net(net)); sock_net_set(sk, hold_net(net));
} }
static inline struct sock *skb_steal_sock(struct sk_buff *skb)
{
if (unlikely(skb->sk)) {
struct sock *sk = skb->sk;
skb->destructor = NULL;
skb->sk = NULL;
return sk;
}
return NULL;
}
extern void sock_enable_timestamp(struct sock *sk); extern void sock_enable_timestamp(struct sock *sk);
extern int sock_get_timestamp(struct sock *, struct timeval __user *); extern int sock_get_timestamp(struct sock *, struct timeval __user *);
extern int sock_get_timestampns(struct sock *, struct timespec __user *); extern int sock_get_timestampns(struct sock *, struct timespec __user *);
......
...@@ -306,11 +306,15 @@ static inline struct sock *__udp4_lib_lookup_skb(struct sk_buff *skb, ...@@ -306,11 +306,15 @@ static inline struct sock *__udp4_lib_lookup_skb(struct sk_buff *skb,
__be16 sport, __be16 dport, __be16 sport, __be16 dport,
struct hlist_head udptable[]) struct hlist_head udptable[])
{ {
struct sock *sk;
const struct iphdr *iph = ip_hdr(skb); const struct iphdr *iph = ip_hdr(skb);
return __udp4_lib_lookup(dev_net(skb->dst->dev), iph->saddr, sport, if (unlikely(sk = skb_steal_sock(skb)))
iph->daddr, dport, inet_iif(skb), return sk;
udptable); else
return __udp4_lib_lookup(dev_net(skb->dst->dev), iph->saddr, sport,
iph->daddr, dport, inet_iif(skb),
udptable);
} }
struct sock *udp4_lib_lookup(struct net *net, __be32 saddr, __be16 sport, struct sock *udp4_lib_lookup(struct net *net, __be32 saddr, __be16 sport,
......
...@@ -111,11 +111,15 @@ static struct sock *__udp6_lib_lookup_skb(struct sk_buff *skb, ...@@ -111,11 +111,15 @@ static struct sock *__udp6_lib_lookup_skb(struct sk_buff *skb,
__be16 sport, __be16 dport, __be16 sport, __be16 dport,
struct hlist_head udptable[]) struct hlist_head udptable[])
{ {
struct sock *sk;
struct ipv6hdr *iph = ipv6_hdr(skb); struct ipv6hdr *iph = ipv6_hdr(skb);
return __udp6_lib_lookup(dev_net(skb->dst->dev), &iph->saddr, sport, if (unlikely(sk = skb_steal_sock(skb)))
&iph->daddr, dport, inet6_iif(skb), return sk;
udptable); else
return __udp6_lib_lookup(dev_net(skb->dst->dev), &iph->saddr, sport,
&iph->daddr, dport, inet6_iif(skb),
udptable);
} }
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment