Commit 2359419f authored by Andres Rodriguez's avatar Andres Rodriguez Committed by Alex Deucher

drm/amdgpu: remove useless pointers from traces

Remove pointers which provide redundant information which is already
easier to deduce from other fields.
Reviewed-by: default avatarChunming Zhou <david1.zhou@amd.com>
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarAndres Rodriguez <andresx7@gmail.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent f6fd2030
...@@ -101,24 +101,20 @@ TRACE_EVENT(amdgpu_cs_ioctl, ...@@ -101,24 +101,20 @@ TRACE_EVENT(amdgpu_cs_ioctl,
TP_PROTO(struct amdgpu_job *job), TP_PROTO(struct amdgpu_job *job),
TP_ARGS(job), TP_ARGS(job),
TP_STRUCT__entry( TP_STRUCT__entry(
__field(struct amdgpu_device *, adev)
__field(uint64_t, sched_job_id) __field(uint64_t, sched_job_id)
__field(struct amdgpu_ib *, ib)
__field(struct dma_fence *, fence) __field(struct dma_fence *, fence)
__field(char *, ring_name) __field(char *, ring_name)
__field(u32, num_ibs) __field(u32, num_ibs)
), ),
TP_fast_assign( TP_fast_assign(
__entry->adev = job->adev;
__entry->sched_job_id = job->base.id; __entry->sched_job_id = job->base.id;
__entry->ib = job->ibs;
__entry->fence = &job->base.s_fence->finished; __entry->fence = &job->base.s_fence->finished;
__entry->ring_name = job->ring->name; __entry->ring_name = job->ring->name;
__entry->num_ibs = job->num_ibs; __entry->num_ibs = job->num_ibs;
), ),
TP_printk("adev=%p, sched_job=%llu, first_ib=%p, sched_fence=%p, ring_name=%s, num_ibs=%u", TP_printk("sched_job=%llu, sched_fence=%p, ring_name=%s, num_ibs=%u",
__entry->adev, __entry->sched_job_id, __entry->ib, __entry->sched_job_id,
__entry->fence, __entry->ring_name, __entry->num_ibs) __entry->fence, __entry->ring_name, __entry->num_ibs)
); );
...@@ -126,10 +122,7 @@ TRACE_EVENT(amdgpu_sched_run_job, ...@@ -126,10 +122,7 @@ TRACE_EVENT(amdgpu_sched_run_job,
TP_PROTO(struct amdgpu_job *job), TP_PROTO(struct amdgpu_job *job),
TP_ARGS(job), TP_ARGS(job),
TP_STRUCT__entry( TP_STRUCT__entry(
__field(struct amdgpu_device *, adev)
__field(uint64_t, sched_job_id) __field(uint64_t, sched_job_id)
__field(struct amdgpu_ib *, ib)
__field(struct dma_fence *, fence)
__string(timeline, job->base.s_fence->finished.ops->get_timeline_name(&job->base.s_fence->finished)) __string(timeline, job->base.s_fence->finished.ops->get_timeline_name(&job->base.s_fence->finished))
__field(unsigned int, context) __field(unsigned int, context)
__field(unsigned int, seqno) __field(unsigned int, seqno)
...@@ -138,20 +131,16 @@ TRACE_EVENT(amdgpu_sched_run_job, ...@@ -138,20 +131,16 @@ TRACE_EVENT(amdgpu_sched_run_job,
), ),
TP_fast_assign( TP_fast_assign(
__entry->adev = job->adev;
__entry->sched_job_id = job->base.id; __entry->sched_job_id = job->base.id;
__entry->ib = job->ibs;
__entry->fence = &job->base.s_fence->finished;
__assign_str(timeline, job->base.s_fence->finished.ops->get_timeline_name(&job->base.s_fence->finished)) __assign_str(timeline, job->base.s_fence->finished.ops->get_timeline_name(&job->base.s_fence->finished))
__entry->context = job->base.s_fence->finished.context; __entry->context = job->base.s_fence->finished.context;
__entry->seqno = job->base.s_fence->finished.seqno; __entry->seqno = job->base.s_fence->finished.seqno;
__entry->ring_name = job->ring->name; __entry->ring_name = job->ring->name;
__entry->num_ibs = job->num_ibs; __entry->num_ibs = job->num_ibs;
), ),
TP_printk("adev=%p, sched_job=%llu, first_ib=%p, sched_fence=%p, timeline=%s, context=%u, seqno=%u, ring_name=%s, num_ibs=%u", TP_printk("sched_job=%llu, timeline=%s, context=%u, seqno=%u, ring_name=%s, num_ibs=%u",
__entry->adev, __entry->sched_job_id, __entry->ib, __entry->sched_job_id, __get_str(timeline), __entry->context,
__entry->fence, __get_str(timeline), __entry->context, __entry->seqno, __entry->seqno, __entry->ring_name, __entry->num_ibs)
__entry->ring_name, __entry->num_ibs)
); );
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment