Commit 24cda109 authored by Jiri Olsa's avatar Jiri Olsa Committed by Ingo Molnar

x86/signals: Clear RF EFLAGS bit for signal handler

Clearing RF EFLAGS bit for signal handler. The reason is
that this flag is set by debug exception code to prevent
the recursive exception entry.

Leaving it set for signal handler might prevent debug
exception of the signal handler itself.
Signed-off-by: default avatarJiri Olsa <jolsa@redhat.com>
Tested-by: default avatarOleg Nesterov <oleg@redhat.com>
Reviewed-by: default avatarFrederic Weisbecker <fweisbec@gmail.com>
Originally-Reported-by: default avatarVince Weaver <vincent.weaver@maine.edu>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Cc: Stephane Eranian <eranian@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarPeter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1367421944-19082-3-git-send-email-jolsa@redhat.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 5e219b3c
...@@ -664,6 +664,12 @@ handle_signal(struct ksignal *ksig, struct pt_regs *regs) ...@@ -664,6 +664,12 @@ handle_signal(struct ksignal *ksig, struct pt_regs *regs)
* Clear the direction flag as per the ABI for function entry. * Clear the direction flag as per the ABI for function entry.
*/ */
regs->flags &= ~X86_EFLAGS_DF; regs->flags &= ~X86_EFLAGS_DF;
/*
* Clear RF when entering the signal handler, because
* it might disable possible debug exception from the
* signal handler.
*/
regs->flags &= ~X86_EFLAGS_RF;
/* /*
* Clear TF when entering the signal handler, but * Clear TF when entering the signal handler, but
* notify any tracer that was single-stepping it. * notify any tracer that was single-stepping it.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment