Commit 24f8cb1e authored by Nanyong Sun's avatar Nanyong Sun Committed by Linus Torvalds

nilfs2: fix memory leak in nilfs_sysfs_create_##name##_group

If kobject_init_and_add return with error, kobject_put() is needed here to
avoid memory leak, because kobject_init_and_add may return error without
freeing the memory associated with the kobject it allocated.

Link: https://lkml.kernel.org/r/20210629022556.3985106-4-sunnanyong@huawei.com
Link: https://lkml.kernel.org/r/1625651306-10829-4-git-send-email-konishi.ryusuke@gmail.comSigned-off-by: default avatarNanyong Sun <sunnanyong@huawei.com>
Signed-off-by: default avatarRyusuke Konishi <konishi.ryusuke@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent dbc6e7d4
...@@ -79,8 +79,8 @@ static int nilfs_sysfs_create_##name##_group(struct the_nilfs *nilfs) \ ...@@ -79,8 +79,8 @@ static int nilfs_sysfs_create_##name##_group(struct the_nilfs *nilfs) \
err = kobject_init_and_add(kobj, &nilfs_##name##_ktype, parent, \ err = kobject_init_and_add(kobj, &nilfs_##name##_ktype, parent, \
#name); \ #name); \
if (err) \ if (err) \
return err; \ kobject_put(kobj); \
return 0; \ return err; \
} \ } \
static void nilfs_sysfs_delete_##name##_group(struct the_nilfs *nilfs) \ static void nilfs_sysfs_delete_##name##_group(struct the_nilfs *nilfs) \
{ \ { \
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment