Commit 2506318e authored by Takashi Iwai's avatar Takashi Iwai

ALSA: hda: Fix regressions on clear and reconfig sysfs

It seems that the HD-audio clear and reconfig sysfs don't work any
longer after the recent driver core change.  There are multiple issues
around that: the linked list corruption and the dead device handling.
The former issue is fixed by another patch for the driver core itself,
while the latter patch needs to be addressed in HD-audio side.

This patch corresponds to the latter, it recovers those broken
functions by replacing the device detach and attach actions with the
standard core API functions, which are almost equivalent with unbind
and bind actions.

Fixes: 65488832 ("driver core: Avoid binding drivers to dead devices")
Cc: <stable@vger.kernel.org>
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=209207
Link: https://lore.kernel.org/r/20201209150119.7705-1-tiwai@suse.deSigned-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 19bb4f78
...@@ -1803,7 +1803,7 @@ int snd_hda_codec_reset(struct hda_codec *codec) ...@@ -1803,7 +1803,7 @@ int snd_hda_codec_reset(struct hda_codec *codec)
return -EBUSY; return -EBUSY;
/* OK, let it free */ /* OK, let it free */
snd_hdac_device_unregister(&codec->core); device_release_driver(hda_codec_dev(codec));
/* allow device access again */ /* allow device access again */
snd_hda_unlock_devices(bus); snd_hda_unlock_devices(bus);
......
...@@ -139,7 +139,7 @@ static int reconfig_codec(struct hda_codec *codec) ...@@ -139,7 +139,7 @@ static int reconfig_codec(struct hda_codec *codec)
"The codec is being used, can't reconfigure.\n"); "The codec is being used, can't reconfigure.\n");
goto error; goto error;
} }
err = snd_hda_codec_configure(codec); err = device_reprobe(hda_codec_dev(codec));
if (err < 0) if (err < 0)
goto error; goto error;
err = snd_card_register(codec->card); err = snd_card_register(codec->card);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment