Commit 25188839 authored by Brian Norris's avatar Brian Norris Committed by Heiko Stuebner

drm/rockchip: dsi: Fix unbalanced clock on probe error

Our probe() function never enabled this clock, so we shouldn't disable
it if we fail to probe the bridge.

Noted by inspection.

Fixes: 2d4f7bda ("drm/rockchip: dsi: migrate to use dw-mipi-dsi bridge driver")
Signed-off-by: default avatarBrian Norris <briannorris@chromium.org>
Reviewed-by: default avatarChen-Yu Tsai <wenst@chromium.org>
Tested-by: default avatarNícolas F. R. A. Prado <nfraprado@collabora.com>
Signed-off-by: default avatarHeiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20210928143413.v3.3.Ie8ceefb51ab6065a1151869b6fcda41a467d4d2c@changeid
parent e584cdc1
...@@ -1433,14 +1433,10 @@ static int dw_mipi_dsi_rockchip_probe(struct platform_device *pdev) ...@@ -1433,14 +1433,10 @@ static int dw_mipi_dsi_rockchip_probe(struct platform_device *pdev)
if (ret != -EPROBE_DEFER) if (ret != -EPROBE_DEFER)
DRM_DEV_ERROR(dev, DRM_DEV_ERROR(dev,
"Failed to probe dw_mipi_dsi: %d\n", ret); "Failed to probe dw_mipi_dsi: %d\n", ret);
goto err_clkdisable; return ret;
} }
return 0; return 0;
err_clkdisable:
clk_disable_unprepare(dsi->pllref_clk);
return ret;
} }
static int dw_mipi_dsi_rockchip_remove(struct platform_device *pdev) static int dw_mipi_dsi_rockchip_remove(struct platform_device *pdev)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment