Commit 2545e072 authored by Dan Carpenter's avatar Dan Carpenter Committed by Steve French

cifs: writing past end of struct in cifs_convert_address()

"s6->sin6_scope_id" is an int bits but strict_strtoul() writes a long
so this can corrupt memory on 64 bit systems.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarJeff Layton <jlayton@redhat.com>
Signed-off-by: default avatarSteve French <sfrench@us.ibm.com>
parent b2a3ad9c
...@@ -197,8 +197,7 @@ cifs_convert_address(struct sockaddr *dst, const char *src, int len) ...@@ -197,8 +197,7 @@ cifs_convert_address(struct sockaddr *dst, const char *src, int len)
memcpy(scope_id, pct + 1, slen); memcpy(scope_id, pct + 1, slen);
scope_id[slen] = '\0'; scope_id[slen] = '\0';
rc = strict_strtoul(scope_id, 0, rc = kstrtouint(scope_id, 0, &s6->sin6_scope_id);
(unsigned long *)&s6->sin6_scope_id);
rc = (rc == 0) ? 1 : 0; rc = (rc == 0) ? 1 : 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment