Commit 2637fd43 authored by Dan Murphy's avatar Dan Murphy Committed by Jacek Anaszewski

leds: ti-lmu-common: Fix coccinelle issue in TI LMU

Fix the coccinelle issues found in the TI LMU common code

drivers/leds/leds-ti-lmu-common.c:97:20-29: WARNING: Unsigned expression compared with zero: ramp_down < 0
drivers/leds/leds-ti-lmu-common.c:97:5-12: WARNING: Unsigned expression compared with zero: ramp_up < 0

Fixes: 3fce8e1e ("leds: TI LMU: Add common code for TI LMU devices")
Signed-off-by: default avatarDan Murphy <dmurphy@ti.com>
Signed-off-by: default avatarJacek Anaszewski <jacek.anaszewski@gmail.com>
parent 070a0eed
...@@ -11,10 +11,10 @@ ...@@ -11,10 +11,10 @@
#include <linux/leds-ti-lmu-common.h> #include <linux/leds-ti-lmu-common.h>
const static int ramp_table[16] = {2048, 262000, 524000, 1049000, 2090000, const static unsigned int ramp_table[16] = {2048, 262000, 524000, 1049000,
4194000, 8389000, 16780000, 33550000, 41940000, 2090000, 4194000, 8389000, 16780000, 33550000,
50330000, 58720000, 67110000, 83880000, 41940000, 50330000, 58720000, 67110000,
100660000, 117440000}; 83880000, 100660000, 117440000};
static int ti_lmu_common_update_brightness(struct ti_lmu_bank *lmu_bank, static int ti_lmu_common_update_brightness(struct ti_lmu_bank *lmu_bank,
int brightness) int brightness)
...@@ -54,7 +54,7 @@ int ti_lmu_common_set_brightness(struct ti_lmu_bank *lmu_bank, int brightness) ...@@ -54,7 +54,7 @@ int ti_lmu_common_set_brightness(struct ti_lmu_bank *lmu_bank, int brightness)
} }
EXPORT_SYMBOL(ti_lmu_common_set_brightness); EXPORT_SYMBOL(ti_lmu_common_set_brightness);
static int ti_lmu_common_convert_ramp_to_index(unsigned int usec) static unsigned int ti_lmu_common_convert_ramp_to_index(unsigned int usec)
{ {
int size = ARRAY_SIZE(ramp_table); int size = ARRAY_SIZE(ramp_table);
int i; int i;
...@@ -78,7 +78,7 @@ static int ti_lmu_common_convert_ramp_to_index(unsigned int usec) ...@@ -78,7 +78,7 @@ static int ti_lmu_common_convert_ramp_to_index(unsigned int usec)
} }
} }
return -EINVAL; return 0;
} }
int ti_lmu_common_set_ramp(struct ti_lmu_bank *lmu_bank) int ti_lmu_common_set_ramp(struct ti_lmu_bank *lmu_bank)
...@@ -94,9 +94,6 @@ int ti_lmu_common_set_ramp(struct ti_lmu_bank *lmu_bank) ...@@ -94,9 +94,6 @@ int ti_lmu_common_set_ramp(struct ti_lmu_bank *lmu_bank)
ramp_down = ti_lmu_common_convert_ramp_to_index(lmu_bank->ramp_down_usec); ramp_down = ti_lmu_common_convert_ramp_to_index(lmu_bank->ramp_down_usec);
} }
if (ramp_up < 0 || ramp_down < 0)
return -EINVAL;
ramp = (ramp_up << 4) | ramp_down; ramp = (ramp_up << 4) | ramp_down;
return regmap_write(regmap, lmu_bank->runtime_ramp_reg, ramp); return regmap_write(regmap, lmu_bank->runtime_ramp_reg, ramp);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment