Commit 2642b112 authored by Stefan Richter's avatar Stefan Richter

ieee1394: sbp2: fix race condition in state change

An intermediate transition from _RUNNING to _IN_SHUTDOWN could have been
missed by the former code.
Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
parent e47c1feb
...@@ -895,12 +895,13 @@ static void sbp2_host_reset(struct hpsb_host *host) ...@@ -895,12 +895,13 @@ static void sbp2_host_reset(struct hpsb_host *host)
return; return;
read_lock_irqsave(&sbp2_hi_logical_units_lock, flags); read_lock_irqsave(&sbp2_hi_logical_units_lock, flags);
list_for_each_entry(lu, &hi->logical_units, lu_list) list_for_each_entry(lu, &hi->logical_units, lu_list)
if (likely(atomic_read(&lu->state) != if (atomic_cmpxchg(&lu->state,
SBP2LU_STATE_IN_SHUTDOWN)) { SBP2LU_STATE_RUNNING, SBP2LU_STATE_IN_RESET)
atomic_set(&lu->state, SBP2LU_STATE_IN_RESET); == SBP2LU_STATE_RUNNING)
scsi_block_requests(lu->shost); scsi_block_requests(lu->shost);
}
read_unlock_irqrestore(&sbp2_hi_logical_units_lock, flags); read_unlock_irqrestore(&sbp2_hi_logical_units_lock, flags);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment