Commit 2656c366 authored by Thomas Gleixner's avatar Thomas Gleixner

genirq: Warn if enable_irq is called before irq is set up

The recent changes in the genirq core unearthed a bug in arch/um which
called enable_irq() before the interrupt was set up.

Warn and return instead of crashing the machine with a NULL pointer
dereference.
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Cc: Richard Weinberger <richard@nod.at>
parent d4429f60
...@@ -324,6 +324,10 @@ void enable_irq(unsigned int irq) ...@@ -324,6 +324,10 @@ void enable_irq(unsigned int irq)
if (!desc) if (!desc)
return; return;
if (WARN(!desc->irq_data.chip || !desc->irq_data.chip->irq_enable,
KERN_ERR "enable_irq before setup/request_irq: irq %u\n", irq))
return;
chip_bus_lock(desc); chip_bus_lock(desc);
raw_spin_lock_irqsave(&desc->lock, flags); raw_spin_lock_irqsave(&desc->lock, flags);
__enable_irq(desc, irq, false); __enable_irq(desc, irq, false);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment