Commit 26a8b094 authored by Johan Hovold's avatar Johan Hovold Committed by Hans de Goede

platform/x86: intel_pmc_core: fix memleak on registration failure

In case device registration fails during module initialisation, the
platform device structure needs to be freed using platform_device_put()
to properly free all resources (e.g. the device name).

Fixes: 938835aa ("platform/x86: intel_pmc_core: do not create a static struct device")
Cc: stable@vger.kernel.org      # 5.9
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20211222105023.6205-1-johan@kernel.orgSigned-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 4f6c131c
...@@ -65,7 +65,7 @@ static int __init pmc_core_platform_init(void) ...@@ -65,7 +65,7 @@ static int __init pmc_core_platform_init(void)
retval = platform_device_register(pmc_core_device); retval = platform_device_register(pmc_core_device);
if (retval) if (retval)
kfree(pmc_core_device); platform_device_put(pmc_core_device);
return retval; return retval;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment