Commit 27a9095a authored by Lorenz Haspel's avatar Lorenz Haspel Committed by Greg Kroah-Hartman

silicom: checkpatch: errors caused by macros

fixed checkpatch error:
added parenthesis around complex macro.

Macro with return was only used once in the code,
so I expandet it in-place.
Signed-off-by: default avatarLorenz Haspel <lorenz@badgers.com>
Signed-off-by: default avatarMichael Banken <michael.banken@mathe.stud.uni-erlangen.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent bbeebecc
...@@ -43,11 +43,6 @@ MODULE_DESCRIPTION(BP_MOD_DESCR); ...@@ -43,11 +43,6 @@ MODULE_DESCRIPTION(BP_MOD_DESCR);
MODULE_VERSION(BP_MOD_VER); MODULE_VERSION(BP_MOD_VER);
spinlock_t bpvm_lock; spinlock_t bpvm_lock;
#define lock_bpctl() \
if (down_interruptible(&bpctl_sema)) { \
return -ERESTARTSYS; \
} \
#define unlock_bpctl() \ #define unlock_bpctl() \
up(&bpctl_sema); up(&bpctl_sema);
...@@ -5414,7 +5409,8 @@ static long device_ioctl(struct file *file, /* see include/linux/fs.h */ ...@@ -5414,7 +5409,8 @@ static long device_ioctl(struct file *file, /* see include/linux/fs.h */
static bpctl_dev_t *pbpctl_dev; static bpctl_dev_t *pbpctl_dev;
/* lock_kernel(); */ /* lock_kernel(); */
lock_bpctl(); if (down_interruptible(&bpctl_sema))
return -ERESTARTSYS;
/* local_irq_save(flags); */ /* local_irq_save(flags); */
/* if(!spin_trylock_irqsave(&bpvm_lock)){ /* if(!spin_trylock_irqsave(&bpvm_lock)){
local_irq_restore(flags); local_irq_restore(flags);
...@@ -7871,7 +7867,8 @@ int bypass_proc_create_dev_sd(bpctl_dev_t *pbp_device_block) ...@@ -7871,7 +7867,8 @@ int bypass_proc_create_dev_sd(bpctl_dev_t *pbp_device_block)
} }
current_pfs->bypass_entry = procfs_dir; current_pfs->bypass_entry = procfs_dir;
#define ENTRY(x) ret |= procfs_add(#x, &x##_ops, pbp_device_block) #define ENTRY(x) (ret |= procfs_add(#x, &x##_ops, pbp_device_block))
ENTRY(bypass_info); ENTRY(bypass_info);
if (pbp_device_block->bp_caps & SW_CTL_CAP) { if (pbp_device_block->bp_caps & SW_CTL_CAP) {
/* Create set param proc's */ /* Create set param proc's */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment