Commit 2936b6ab authored by Sridhar Samudrala's avatar Sridhar Samudrala Committed by David S. Miller

vxlan: Avoid creating fdb entry with NULL destination

Commit afbd8bae
   vxlan: add implicit fdb entry for default destination
creates an implicit fdb entry for default destination. This results
in an invalid fdb entry if default destination is not specified.
For ex:
  ip link add vxlan1 type vxlan id 100
creates the following fdb entry
  00:00:00:00:00:00 dev vxlan1 dst 0.0.0.0 self permanent

This patch fixes this issue by creating an fdb entry only if a
valid default destination is specified.
Signed-off-by: default avatarSridhar Samudrala <sri@us.ibm.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 269aa759
...@@ -2490,15 +2490,19 @@ static int vxlan_newlink(struct net *net, struct net_device *dev, ...@@ -2490,15 +2490,19 @@ static int vxlan_newlink(struct net *net, struct net_device *dev,
SET_ETHTOOL_OPS(dev, &vxlan_ethtool_ops); SET_ETHTOOL_OPS(dev, &vxlan_ethtool_ops);
/* create an fdb entry for default destination */ /* create an fdb entry for a valid default destination */
err = vxlan_fdb_create(vxlan, all_zeros_mac, if (!vxlan_addr_any(&vxlan->default_dst.remote_ip)) {
&vxlan->default_dst.remote_ip, err = vxlan_fdb_create(vxlan, all_zeros_mac,
NUD_REACHABLE|NUD_PERMANENT, &vxlan->default_dst.remote_ip,
NLM_F_EXCL|NLM_F_CREATE, NUD_REACHABLE|NUD_PERMANENT,
vxlan->dst_port, vxlan->default_dst.remote_vni, NLM_F_EXCL|NLM_F_CREATE,
vxlan->default_dst.remote_ifindex, NTF_SELF); vxlan->dst_port,
if (err) vxlan->default_dst.remote_vni,
return err; vxlan->default_dst.remote_ifindex,
NTF_SELF);
if (err)
return err;
}
err = register_netdevice(dev); err = register_netdevice(dev);
if (err) { if (err) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment