Commit 299d7572 authored by Johan Hovold's avatar Johan Hovold

USB: serial: console: fix use-after-free after failed setup

Make sure to reset the USB-console port pointer when console setup fails
in order to avoid having the struct usb_serial be prematurely freed by
the console code when the device is later disconnected.

Fixes: 73e487fd ("[PATCH] USB console: fix disconnection issues")
Cc: stable <stable@vger.kernel.org>	# 2.6.18
Acked-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
parent bd998c2e
...@@ -186,6 +186,7 @@ static int usb_console_setup(struct console *co, char *options) ...@@ -186,6 +186,7 @@ static int usb_console_setup(struct console *co, char *options)
tty_kref_put(tty); tty_kref_put(tty);
reset_open_count: reset_open_count:
port->port.count = 0; port->port.count = 0;
info->port = NULL;
usb_autopm_put_interface(serial->interface); usb_autopm_put_interface(serial->interface);
error_get_interface: error_get_interface:
usb_serial_put(serial); usb_serial_put(serial);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment