Commit 29ca3cdf authored by Antoine Tenart's avatar Antoine Tenart Committed by David S. Miller

net: macsec: fix rtnl locking issue

netdev_update_features() must be called with the rtnl lock taken. Not
doing so triggers a warning, as ASSERT_RTNL() is used in
__netdev_update_features(), the first function called by
netdev_update_features(). Fix this.

Fixes: c850240b ("net: macsec: report real_dev features when HW offloading is enabled")
Signed-off-by: default avatarAntoine Tenart <antoine.tenart@bootlin.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 722c0f00
...@@ -2641,11 +2641,12 @@ static int macsec_upd_offload(struct sk_buff *skb, struct genl_info *info) ...@@ -2641,11 +2641,12 @@ static int macsec_upd_offload(struct sk_buff *skb, struct genl_info *info)
if (ret) if (ret)
goto rollback; goto rollback;
rtnl_unlock();
/* Force features update, since they are different for SW MACSec and /* Force features update, since they are different for SW MACSec and
* HW offloading cases. * HW offloading cases.
*/ */
netdev_update_features(dev); netdev_update_features(dev);
rtnl_unlock();
return 0; return 0;
rollback: rollback:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment