Commit 2a7ca745 authored by Wang Hai's avatar Wang Hai Committed by Marcel Holtmann

Bluetooth: cmtp: fix possible panic when cmtp_init_sockets() fails

I got a kernel BUG report when doing fault injection test:

------------[ cut here ]------------
kernel BUG at lib/list_debug.c:45!
...
RIP: 0010:__list_del_entry_valid.cold+0x12/0x4d
...
Call Trace:
 proto_unregister+0x83/0x220
 cmtp_cleanup_sockets+0x37/0x40 [cmtp]
 cmtp_exit+0xe/0x1f [cmtp]
 do_syscall_64+0x35/0xb0
 entry_SYSCALL_64_after_hwframe+0x44/0xae

If cmtp_init_sockets() in cmtp_init() fails, cmtp_init() still returns
success. This will cause a kernel bug when accessing uncreated ctmp
related data when the module exits.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarWang Hai <wanghai38@huawei.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent f33b0068
...@@ -501,9 +501,7 @@ static int __init cmtp_init(void) ...@@ -501,9 +501,7 @@ static int __init cmtp_init(void)
{ {
BT_INFO("CMTP (CAPI Emulation) ver %s", VERSION); BT_INFO("CMTP (CAPI Emulation) ver %s", VERSION);
cmtp_init_sockets(); return cmtp_init_sockets();
return 0;
} }
static void __exit cmtp_exit(void) static void __exit cmtp_exit(void)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment