Commit 2b22df83 authored by Tomi Valkeinen's avatar Tomi Valkeinen

OMAPDSS: HDMI: fix devm_ioremap_resource error checks

devm_ioremap_resource returns ERR_PTR on error, not NULL. Fix the
error checks in the driver.
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent 2dcfdc30
...@@ -1009,9 +1009,9 @@ int hdmi4_core_init(struct platform_device *pdev, struct hdmi_core_data *core) ...@@ -1009,9 +1009,9 @@ int hdmi4_core_init(struct platform_device *pdev, struct hdmi_core_data *core)
} }
core->base = devm_ioremap_resource(&pdev->dev, res); core->base = devm_ioremap_resource(&pdev->dev, res);
if (!core->base) { if (IS_ERR(core->base)) {
DSSERR("can't ioremap CORE\n"); DSSERR("can't ioremap CORE\n");
return -ENOMEM; return PTR_ERR(core->base);
} }
return 0; return 0;
......
...@@ -913,9 +913,9 @@ int hdmi5_core_init(struct platform_device *pdev, struct hdmi_core_data *core) ...@@ -913,9 +913,9 @@ int hdmi5_core_init(struct platform_device *pdev, struct hdmi_core_data *core)
} }
core->base = devm_ioremap_resource(&pdev->dev, res); core->base = devm_ioremap_resource(&pdev->dev, res);
if (!core->base) { if (IS_ERR(core->base)) {
DSSERR("can't ioremap HDMI core\n"); DSSERR("can't ioremap HDMI core\n");
return -ENOMEM; return PTR_ERR(core->base);
} }
return 0; return 0;
......
...@@ -246,9 +246,9 @@ int hdmi_phy_init(struct platform_device *pdev, struct hdmi_phy_data *phy) ...@@ -246,9 +246,9 @@ int hdmi_phy_init(struct platform_device *pdev, struct hdmi_phy_data *phy)
} }
phy->base = devm_ioremap_resource(&pdev->dev, res); phy->base = devm_ioremap_resource(&pdev->dev, res);
if (!phy->base) { if (IS_ERR(phy->base)) {
DSSERR("can't ioremap TX PHY\n"); DSSERR("can't ioremap TX PHY\n");
return -ENOMEM; return PTR_ERR(phy->base);
} }
return 0; return 0;
......
...@@ -282,9 +282,9 @@ int hdmi_pll_init(struct platform_device *pdev, struct hdmi_pll_data *pll) ...@@ -282,9 +282,9 @@ int hdmi_pll_init(struct platform_device *pdev, struct hdmi_pll_data *pll)
} }
pll->base = devm_ioremap_resource(&pdev->dev, res); pll->base = devm_ioremap_resource(&pdev->dev, res);
if (!pll->base) { if (IS_ERR(pll->base)) {
DSSERR("can't ioremap PLLCTRL\n"); DSSERR("can't ioremap PLLCTRL\n");
return -ENOMEM; return PTR_ERR(pll->base);
} }
return 0; return 0;
......
...@@ -249,9 +249,9 @@ int hdmi_wp_init(struct platform_device *pdev, struct hdmi_wp_data *wp) ...@@ -249,9 +249,9 @@ int hdmi_wp_init(struct platform_device *pdev, struct hdmi_wp_data *wp)
} }
wp->base = devm_ioremap_resource(&pdev->dev, res); wp->base = devm_ioremap_resource(&pdev->dev, res);
if (!wp->base) { if (IS_ERR(wp->base)) {
DSSERR("can't ioremap HDMI WP\n"); DSSERR("can't ioremap HDMI WP\n");
return -ENOMEM; return PTR_ERR(wp->base);
} }
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment