Commit 2bc75964 authored by Kristaps Čivkulis's avatar Kristaps Čivkulis Committed by Greg Kroah-Hartman

staging: erofs: fix if assignment style issue

Fix coding style issue "do not use assignment in if condition"
detected by checkpatch.pl.
Signed-off-by: default avatarKristaps Čivkulis <kristaps.civkulis@gmail.com>
Reviewed-by: default avatarGao Xiang <gaoxiang25@huawei.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1061bdba
...@@ -702,7 +702,8 @@ static int z_erofs_do_read_page(struct z_erofs_vle_frontend *fe, ...@@ -702,7 +702,8 @@ static int z_erofs_do_read_page(struct z_erofs_vle_frontend *fe,
/* can be used for verification */ /* can be used for verification */
map->m_llen = offset + cur - map->m_la; map->m_llen = offset + cur - map->m_la;
if ((end = cur) > 0) end = cur;
if (end > 0)
goto repeat; goto repeat;
/* FIXME! avoid the last relundant fixup & endio */ /* FIXME! avoid the last relundant fixup & endio */
......
...@@ -288,8 +288,8 @@ static int inline_getxattr(struct inode *inode, struct getxattr_iter *it) ...@@ -288,8 +288,8 @@ static int inline_getxattr(struct inode *inode, struct getxattr_iter *it)
remaining = ret; remaining = ret;
while (remaining) { while (remaining) {
if ((ret = xattr_foreach(&it->it, ret = xattr_foreach(&it->it, &find_xattr_handlers, &remaining);
&find_xattr_handlers, &remaining)) >= 0) if (ret >= 0)
break; break;
} }
xattr_iter_end(&it->it, true); xattr_iter_end(&it->it, true);
...@@ -321,8 +321,8 @@ static int shared_getxattr(struct inode *inode, struct getxattr_iter *it) ...@@ -321,8 +321,8 @@ static int shared_getxattr(struct inode *inode, struct getxattr_iter *it)
it->it.blkaddr = blkaddr; it->it.blkaddr = blkaddr;
} }
if ((ret = xattr_foreach(&it->it, ret = xattr_foreach(&it->it, &find_xattr_handlers, NULL);
&find_xattr_handlers, NULL)) >= 0) if (ret >= 0)
break; break;
} }
if (vi->xattr_shared_count) if (vi->xattr_shared_count)
...@@ -512,8 +512,8 @@ static int inline_listxattr(struct listxattr_iter *it) ...@@ -512,8 +512,8 @@ static int inline_listxattr(struct listxattr_iter *it)
remaining = ret; remaining = ret;
while (remaining) { while (remaining) {
if ((ret = xattr_foreach(&it->it, ret = xattr_foreach(&it->it, &list_xattr_handlers, &remaining);
&list_xattr_handlers, &remaining)) < 0) if (ret < 0)
break; break;
} }
xattr_iter_end(&it->it, true); xattr_iter_end(&it->it, true);
...@@ -544,8 +544,8 @@ static int shared_listxattr(struct listxattr_iter *it) ...@@ -544,8 +544,8 @@ static int shared_listxattr(struct listxattr_iter *it)
it->it.blkaddr = blkaddr; it->it.blkaddr = blkaddr;
} }
if ((ret = xattr_foreach(&it->it, ret = xattr_foreach(&it->it, &list_xattr_handlers, NULL);
&list_xattr_handlers, NULL)) < 0) if (ret < 0)
break; break;
} }
if (vi->xattr_shared_count) if (vi->xattr_shared_count)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment