Commit 2bf95456 authored by Wang Xiaojun's avatar Wang Xiaojun Committed by Wolfram Sang

i2c: mlxbf: Fix the return check of devm_ioremap and ioremap

devm_ioremap and ioremap may return NULL which cannot be checked
by IS_ERR.
Signed-off-by: default avatarWang Xiaojun <wangxiaojun11@huawei.com>
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Acked-by: default avatarKhalil Blaiech <kblaiech@nvidia.com>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent c62dac0a
...@@ -1258,9 +1258,9 @@ static int mlxbf_i2c_get_gpio(struct platform_device *pdev, ...@@ -1258,9 +1258,9 @@ static int mlxbf_i2c_get_gpio(struct platform_device *pdev,
return -EFAULT; return -EFAULT;
gpio_res->io = devm_ioremap(dev, params->start, size); gpio_res->io = devm_ioremap(dev, params->start, size);
if (IS_ERR(gpio_res->io)) { if (!gpio_res->io) {
devm_release_mem_region(dev, params->start, size); devm_release_mem_region(dev, params->start, size);
return PTR_ERR(gpio_res->io); return -ENOMEM;
} }
return 0; return 0;
...@@ -1323,9 +1323,9 @@ static int mlxbf_i2c_get_corepll(struct platform_device *pdev, ...@@ -1323,9 +1323,9 @@ static int mlxbf_i2c_get_corepll(struct platform_device *pdev,
return -EFAULT; return -EFAULT;
corepll_res->io = devm_ioremap(dev, params->start, size); corepll_res->io = devm_ioremap(dev, params->start, size);
if (IS_ERR(corepll_res->io)) { if (!corepll_res->io) {
devm_release_mem_region(dev, params->start, size); devm_release_mem_region(dev, params->start, size);
return PTR_ERR(corepll_res->io); return -ENOMEM;
} }
return 0; return 0;
...@@ -1717,9 +1717,9 @@ static int mlxbf_i2c_init_coalesce(struct platform_device *pdev, ...@@ -1717,9 +1717,9 @@ static int mlxbf_i2c_init_coalesce(struct platform_device *pdev,
return -EFAULT; return -EFAULT;
coalesce_res->io = ioremap(params->start, size); coalesce_res->io = ioremap(params->start, size);
if (IS_ERR(coalesce_res->io)) { if (!coalesce_res->io) {
release_mem_region(params->start, size); release_mem_region(params->start, size);
return PTR_ERR(coalesce_res->io); return -ENOMEM;
} }
priv->coalesce = coalesce_res; priv->coalesce = coalesce_res;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment