Commit 2ce19934 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Jakub Kicinski

net: fjes: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Link: https://lore.kernel.org/r/20231117095922.876489-4-u.kleine-koenig@pengutronix.deSigned-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/4889ac6a7ffa9b02fa5cdd2d3212e739741f80b8.1701713943.git.u.kleine-koenig@pengutronix.deSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent a92dbb9c
...@@ -1438,7 +1438,7 @@ static int fjes_probe(struct platform_device *plat_dev) ...@@ -1438,7 +1438,7 @@ static int fjes_probe(struct platform_device *plat_dev)
} }
/* fjes_remove - Device Removal Routine */ /* fjes_remove - Device Removal Routine */
static int fjes_remove(struct platform_device *plat_dev) static void fjes_remove(struct platform_device *plat_dev)
{ {
struct net_device *netdev = dev_get_drvdata(&plat_dev->dev); struct net_device *netdev = dev_get_drvdata(&plat_dev->dev);
struct fjes_adapter *adapter = netdev_priv(netdev); struct fjes_adapter *adapter = netdev_priv(netdev);
...@@ -1462,8 +1462,6 @@ static int fjes_remove(struct platform_device *plat_dev) ...@@ -1462,8 +1462,6 @@ static int fjes_remove(struct platform_device *plat_dev)
netif_napi_del(&adapter->napi); netif_napi_del(&adapter->napi);
free_netdev(netdev); free_netdev(netdev);
return 0;
} }
static struct platform_driver fjes_driver = { static struct platform_driver fjes_driver = {
...@@ -1471,7 +1469,7 @@ static struct platform_driver fjes_driver = { ...@@ -1471,7 +1469,7 @@ static struct platform_driver fjes_driver = {
.name = DRV_NAME, .name = DRV_NAME,
}, },
.probe = fjes_probe, .probe = fjes_probe,
.remove = fjes_remove, .remove_new = fjes_remove,
}; };
static acpi_status static acpi_status
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment