Commit 2d1c82c4 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Mark Brown

ASoC: fsl: fsl_ssi: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: default avatarTakashi Iwai <tiwai@suse.de>
Acked-by: default avatarNicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20230315150745.67084-75-u.kleine-koenig@pengutronix.deSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent c8c0bd47
...@@ -1671,7 +1671,7 @@ static int fsl_ssi_probe(struct platform_device *pdev) ...@@ -1671,7 +1671,7 @@ static int fsl_ssi_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int fsl_ssi_remove(struct platform_device *pdev) static void fsl_ssi_remove(struct platform_device *pdev)
{ {
struct fsl_ssi *ssi = dev_get_drvdata(&pdev->dev); struct fsl_ssi *ssi = dev_get_drvdata(&pdev->dev);
...@@ -1690,8 +1690,6 @@ static int fsl_ssi_remove(struct platform_device *pdev) ...@@ -1690,8 +1690,6 @@ static int fsl_ssi_remove(struct platform_device *pdev)
snd_soc_set_ac97_ops(NULL); snd_soc_set_ac97_ops(NULL);
mutex_destroy(&ssi->ac97_reg_lock); mutex_destroy(&ssi->ac97_reg_lock);
} }
return 0;
} }
#ifdef CONFIG_PM_SLEEP #ifdef CONFIG_PM_SLEEP
...@@ -1737,7 +1735,7 @@ static struct platform_driver fsl_ssi_driver = { ...@@ -1737,7 +1735,7 @@ static struct platform_driver fsl_ssi_driver = {
.pm = &fsl_ssi_pm, .pm = &fsl_ssi_pm,
}, },
.probe = fsl_ssi_probe, .probe = fsl_ssi_probe,
.remove = fsl_ssi_remove, .remove_new = fsl_ssi_remove,
}; };
module_platform_driver(fsl_ssi_driver); module_platform_driver(fsl_ssi_driver);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment