Commit 2d52d172 authored by Dan Carpenter's avatar Dan Carpenter Committed by Mark Brown

ASoC: wm8741: check for error returns from wm8741_set_pdata()

Static checkers complain that "ret" is always zero so the conditions are
never true.

The intention here was clearly to check for errors from
wm8741_set_pdata().  Although, since wm8741_set_pdata() never returns
errors, it doesn't affect runtime.

Fixes: c354b54c ('ASoC: wm8741: Add differential mono mode support')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarCharles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent c354b54c
......@@ -613,7 +613,7 @@ static int wm8741_i2c_probe(struct i2c_client *i2c,
return ret;
}
wm8741_set_pdata(&i2c->dev, wm8741);
ret = wm8741_set_pdata(&i2c->dev, wm8741);
if (ret != 0) {
dev_err(&i2c->dev, "Failed to set pdata: %d\n", ret);
return ret;
......@@ -679,7 +679,7 @@ static int wm8741_spi_probe(struct spi_device *spi)
return ret;
}
wm8741_set_pdata(&spi->dev, wm8741);
ret = wm8741_set_pdata(&spi->dev, wm8741);
if (ret != 0) {
dev_err(&spi->dev, "Failed to set pdata: %d\n", ret);
return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment