Commit 2e546755 authored by Sujith Manoharan's avatar Sujith Manoharan Committed by John W. Linville

ath9k: Fix RTS/CTS rate selection

The current method of assigning the RTS/CTS rate is completely
broken for HT mode and breaks P2P operation. Fix this by using
the basic_rates provided to the driver by mac80211. For now,
choose the lowest supported basic rate for HT frames.
Signed-off-by: default avatarSujith Manoharan <c_manoha@qca.qualcomm.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 97f7e8a7
...@@ -699,37 +699,25 @@ static void ath_rc_rate_set_rtscts(struct ath_softc *sc, ...@@ -699,37 +699,25 @@ static void ath_rc_rate_set_rtscts(struct ath_softc *sc,
const struct ath_rate_table *rate_table, const struct ath_rate_table *rate_table,
struct ieee80211_tx_info *tx_info) struct ieee80211_tx_info *tx_info)
{ {
struct ieee80211_tx_rate *rates = tx_info->control.rates; struct ieee80211_bss_conf *bss_conf;
int i = 0, rix = 0, cix, enable_g_protection = 0;
/* get the cix for the lowest valid rix */ if (!tx_info->control.vif)
for (i = 3; i >= 0; i--) { return;
if (rates[i].count && (rates[i].idx >= 0)) { /*
rix = ath_rc_get_rateindex(rate_table, &rates[i]); * For legacy frames, mac80211 takes care of CTS protection.
break; */
} if (!(tx_info->control.rates[0].flags & IEEE80211_TX_RC_MCS))
} return;
cix = rate_table->info[rix].ctrl_rate;
bss_conf = &tx_info->control.vif->bss_conf;
/* All protection frames are transmited at 2Mb/s for 802.11g, if (!bss_conf->basic_rates)
* otherwise we transmit them at 1Mb/s */ return;
if (sc->hw->conf.channel->band == IEEE80211_BAND_2GHZ &&
!conf_is_ht(&sc->hw->conf))
enable_g_protection = 1;
/* /*
* If 802.11g protection is enabled, determine whether to use RTS/CTS or * For now, use the lowest allowed basic rate for HT frames.
* just CTS. Note that this is only done for OFDM/HT unicast frames.
*/ */
if ((tx_info->control.vif && tx_info->control.rts_cts_rate_idx = __ffs(bss_conf->basic_rates);
tx_info->control.vif->bss_conf.use_cts_prot) &&
(rate_table->info[rix].phy == WLAN_RC_PHY_OFDM ||
WLAN_RC_PHY_HT(rate_table->info[rix].phy))) {
rates[0].flags |= IEEE80211_TX_RC_USE_CTS_PROTECT;
cix = rate_table->info[enable_g_protection].ctrl_rate;
}
tx_info->control.rts_cts_rate_idx = cix;
} }
static void ath_get_rate(void *priv, struct ieee80211_sta *sta, void *priv_sta, static void ath_get_rate(void *priv, struct ieee80211_sta *sta, void *priv_sta,
...@@ -853,7 +841,6 @@ static void ath_get_rate(void *priv, struct ieee80211_sta *sta, void *priv_sta, ...@@ -853,7 +841,6 @@ static void ath_get_rate(void *priv, struct ieee80211_sta *sta, void *priv_sta,
rates[0].count = ATH_TXMAXTRY; rates[0].count = ATH_TXMAXTRY;
} }
/* Setup RTS/CTS */
ath_rc_rate_set_rtscts(sc, rate_table, tx_info); ath_rc_rate_set_rtscts(sc, rate_table, tx_info);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment