Commit 2f2d8630 authored by Howard Hsu's avatar Howard Hsu Committed by Felix Fietkau

wifi: mt76: mt7915: add error message in mt7915_thermal_set_cur_throttle_state()

Add dev_err so that it is easier to see invalid setting while looking at
dmesg.
Co-developed-by: default avatarRyder Lee <ryder.lee@mediatek.com>
Signed-off-by: default avatarRyder Lee <ryder.lee@mediatek.com>
Signed-off-by: default avatarHoward Hsu <howard-yh.hsu@mediatek.com>
Signed-off-by: default avatarFelix Fietkau <nbd@nbd.name>
parent ecaccdae
...@@ -145,8 +145,11 @@ mt7915_thermal_set_cur_throttle_state(struct thermal_cooling_device *cdev, ...@@ -145,8 +145,11 @@ mt7915_thermal_set_cur_throttle_state(struct thermal_cooling_device *cdev,
u8 throttling = MT7915_THERMAL_THROTTLE_MAX - state; u8 throttling = MT7915_THERMAL_THROTTLE_MAX - state;
int ret; int ret;
if (state > MT7915_CDEV_THROTTLE_MAX) if (state > MT7915_CDEV_THROTTLE_MAX) {
dev_err(phy->dev->mt76.dev,
"please specify a valid throttling state\n");
return -EINVAL; return -EINVAL;
}
if (state == phy->cdev_state) if (state == phy->cdev_state)
return 0; return 0;
...@@ -175,7 +178,7 @@ static void mt7915_unregister_thermal(struct mt7915_phy *phy) ...@@ -175,7 +178,7 @@ static void mt7915_unregister_thermal(struct mt7915_phy *phy)
struct wiphy *wiphy = phy->mt76->hw->wiphy; struct wiphy *wiphy = phy->mt76->hw->wiphy;
if (!phy->cdev) if (!phy->cdev)
return; return;
sysfs_remove_link(&wiphy->dev.kobj, "cooling_device"); sysfs_remove_link(&wiphy->dev.kobj, "cooling_device");
thermal_cooling_device_unregister(phy->cdev); thermal_cooling_device_unregister(phy->cdev);
...@@ -209,8 +212,8 @@ static int mt7915_thermal_init(struct mt7915_phy *phy) ...@@ -209,8 +212,8 @@ static int mt7915_thermal_init(struct mt7915_phy *phy)
return PTR_ERR(hwmon); return PTR_ERR(hwmon);
/* initialize critical/maximum high temperature */ /* initialize critical/maximum high temperature */
phy->throttle_temp[MT7915_CRIT_TEMP_IDX] = 110; phy->throttle_temp[MT7915_CRIT_TEMP_IDX] = MT7915_CRIT_TEMP;
phy->throttle_temp[MT7915_MAX_TEMP_IDX] = 120; phy->throttle_temp[MT7915_MAX_TEMP_IDX] = MT7915_MAX_TEMP;
return 0; return 0;
} }
...@@ -1182,7 +1185,6 @@ static void mt7915_stop_hardware(struct mt7915_dev *dev) ...@@ -1182,7 +1185,6 @@ static void mt7915_stop_hardware(struct mt7915_dev *dev)
mt7986_wmac_disable(dev); mt7986_wmac_disable(dev);
} }
int mt7915_register_device(struct mt7915_dev *dev) int mt7915_register_device(struct mt7915_dev *dev)
{ {
struct mt7915_phy *phy2; struct mt7915_phy *phy2;
......
...@@ -72,6 +72,8 @@ ...@@ -72,6 +72,8 @@
#define MT7915_CRIT_TEMP_IDX 0 #define MT7915_CRIT_TEMP_IDX 0
#define MT7915_MAX_TEMP_IDX 1 #define MT7915_MAX_TEMP_IDX 1
#define MT7915_CRIT_TEMP 110
#define MT7915_MAX_TEMP 120
struct mt7915_vif; struct mt7915_vif;
struct mt7915_sta; struct mt7915_sta;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment