Commit 2f57b8d5 authored by Fabio Estevam's avatar Fabio Estevam Committed by Vinod Koul

dmaengine: imx-sdma: Fix: Remove 'always true' comparison

event_id0 is defined as 'unsigned int', so it is always greater or
equal to zero.

Remove the unneeded comparisons to fix the following W=1 build
warning:

drivers/dma/imx-sdma.c: In function 'sdma_free_chan_resources':
drivers/dma/imx-sdma.c:1334:23: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
1334 |  if (sdmac->event_id0 >= 0)
|                       ^~
drivers/dma/imx-sdma.c: In function 'sdma_config':
drivers/dma/imx-sdma.c:1635:23: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
1635 |  if (sdmac->event_id0 >= 0) {
|

Fixes: 25962e1a ("dmaengine: imx-sdma: Fix the event id check to include RX event for UART6")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarFabio Estevam <festevam@gmail.com>
Reviewed-by: default avatarFrieder Schrempf <frieder.schrempf@kontron.de>
Link: https://lore.kernel.org/r/20200621155730.28766-1-festevam@gmail.comSigned-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 1aea5c13
...@@ -1331,8 +1331,7 @@ static void sdma_free_chan_resources(struct dma_chan *chan) ...@@ -1331,8 +1331,7 @@ static void sdma_free_chan_resources(struct dma_chan *chan)
sdma_channel_synchronize(chan); sdma_channel_synchronize(chan);
if (sdmac->event_id0 >= 0) sdma_event_disable(sdmac, sdmac->event_id0);
sdma_event_disable(sdmac, sdmac->event_id0);
if (sdmac->event_id1) if (sdmac->event_id1)
sdma_event_disable(sdmac, sdmac->event_id1); sdma_event_disable(sdmac, sdmac->event_id1);
...@@ -1632,11 +1631,9 @@ static int sdma_config(struct dma_chan *chan, ...@@ -1632,11 +1631,9 @@ static int sdma_config(struct dma_chan *chan,
memcpy(&sdmac->slave_config, dmaengine_cfg, sizeof(*dmaengine_cfg)); memcpy(&sdmac->slave_config, dmaengine_cfg, sizeof(*dmaengine_cfg));
/* Set ENBLn earlier to make sure dma request triggered after that */ /* Set ENBLn earlier to make sure dma request triggered after that */
if (sdmac->event_id0 >= 0) { if (sdmac->event_id0 >= sdmac->sdma->drvdata->num_events)
if (sdmac->event_id0 >= sdmac->sdma->drvdata->num_events) return -EINVAL;
return -EINVAL; sdma_event_enable(sdmac, sdmac->event_id0);
sdma_event_enable(sdmac, sdmac->event_id0);
}
if (sdmac->event_id1) { if (sdmac->event_id1) {
if (sdmac->event_id1 >= sdmac->sdma->drvdata->num_events) if (sdmac->event_id1 >= sdmac->sdma->drvdata->num_events)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment