Commit 2f64dc70 authored by Nishka Dasgupta's avatar Nishka Dasgupta Committed by Geert Uytterhoeven

pinctrl: rzn1: Add of_node_put() before return

Each iteration of for_each_child_of_node puts the previous node, but in
the case of a return from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the return in
three places.
Issue found with Coccinelle.
Signed-off-by: default avatarNishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
parent 5f9e832c
...@@ -412,8 +412,10 @@ static int rzn1_dt_node_to_map(struct pinctrl_dev *pctldev, ...@@ -412,8 +412,10 @@ static int rzn1_dt_node_to_map(struct pinctrl_dev *pctldev,
for_each_child_of_node(np, child) { for_each_child_of_node(np, child) {
ret = rzn1_dt_node_to_map_one(pctldev, child, map, num_maps); ret = rzn1_dt_node_to_map_one(pctldev, child, map, num_maps);
if (ret < 0) if (ret < 0) {
of_node_put(child);
return ret; return ret;
}
} }
return 0; return 0;
...@@ -792,8 +794,10 @@ static int rzn1_pinctrl_parse_functions(struct device_node *np, ...@@ -792,8 +794,10 @@ static int rzn1_pinctrl_parse_functions(struct device_node *np,
grp = &ipctl->groups[ipctl->ngroups]; grp = &ipctl->groups[ipctl->ngroups];
grp->func = func->name; grp->func = func->name;
ret = rzn1_pinctrl_parse_groups(child, grp, ipctl); ret = rzn1_pinctrl_parse_groups(child, grp, ipctl);
if (ret < 0) if (ret < 0) {
of_node_put(child);
return ret; return ret;
}
i++; i++;
ipctl->ngroups++; ipctl->ngroups++;
} }
...@@ -838,8 +842,10 @@ static int rzn1_pinctrl_probe_dt(struct platform_device *pdev, ...@@ -838,8 +842,10 @@ static int rzn1_pinctrl_probe_dt(struct platform_device *pdev,
for_each_child_of_node(np, child) { for_each_child_of_node(np, child) {
ret = rzn1_pinctrl_parse_functions(child, ipctl, i++); ret = rzn1_pinctrl_parse_functions(child, ipctl, i++);
if (ret < 0) if (ret < 0) {
of_node_put(child);
return ret; return ret;
}
} }
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment