Commit 2fd3c5c6 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller

ide: make drive->dn read only

The IDE core always sets ->dn correctly so changing it is never
required.

Setting it to a different value than assigned by IDE core is very likely
to result in data corruption (due to wrong transfer timings being set on
the controller etc.)
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Tested-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ce1f31b4
...@@ -206,7 +206,7 @@ static int set_xfer_rate (ide_drive_t *drive, int arg) ...@@ -206,7 +206,7 @@ static int set_xfer_rate (ide_drive_t *drive, int arg)
ide_devset_rw(current_speed, xfer_rate); ide_devset_rw(current_speed, xfer_rate);
ide_devset_rw_field(init_speed, init_speed); ide_devset_rw_field(init_speed, init_speed);
ide_devset_rw_flag(nice1, IDE_DFLAG_NICE1); ide_devset_rw_flag(nice1, IDE_DFLAG_NICE1);
ide_devset_rw_field(number, dn); ide_devset_ro_field(number, dn);
static const struct ide_proc_devset ide_generic_settings[] = { static const struct ide_proc_devset ide_generic_settings[] = {
IDE_PROC_DEVSET(current_speed, 0, 70), IDE_PROC_DEVSET(current_speed, 0, 70),
......
...@@ -943,6 +943,10 @@ ide_devset_get(_name, _field); \ ...@@ -943,6 +943,10 @@ ide_devset_get(_name, _field); \
ide_devset_set(_name, _field); \ ide_devset_set(_name, _field); \
IDE_DEVSET(_name, DS_SYNC, get_##_name, set_##_name) IDE_DEVSET(_name, DS_SYNC, get_##_name, set_##_name)
#define ide_devset_ro_field(_name, _field) \
ide_devset_get(_name, _field); \
IDE_DEVSET(_name, 0, get_##_name, NULL)
#define ide_devset_rw_flag(_name, _field) \ #define ide_devset_rw_flag(_name, _field) \
ide_devset_get_flag(_name, _field); \ ide_devset_get_flag(_name, _field); \
ide_devset_set_flag(_name, _field); \ ide_devset_set_flag(_name, _field); \
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment