Commit 2ffabf50 authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman

staging: r8822be: fix memory leak of eeprom_map on error exit return

A memory leak of eeprom_map occurs if the call to halmac_eeprom_parser_88xx
fails. Fix this by kfree'ing it before returning.

Detected by CoverityScan, CID#1454569 ("Resource leak")
Fixes: 938a0447 ("staging: r8822be: Add code for halmac sub-driver")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent faff950c
......@@ -1950,8 +1950,10 @@ halmac_dump_logical_efuse_map_88xx(struct halmac_adapter *halmac_adapter,
if (halmac_eeprom_parser_88xx(halmac_adapter,
halmac_adapter->hal_efuse_map,
eeprom_map) != HALMAC_RET_SUCCESS)
eeprom_map) != HALMAC_RET_SUCCESS) {
kfree(eeprom_map);
return HALMAC_RET_EEPROM_PARSING_FAIL;
}
PLATFORM_EVENT_INDICATION(
driver_adapter, HALMAC_FEATURE_DUMP_LOGICAL_EFUSE,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment