Commit 30230644 authored by chenzefeng (A)'s avatar chenzefeng (A) Committed by Stefan Bader

x86: livepatch: Treat R_X86_64_PLT32 as R_X86_64_PC32

BugLink: https://bugs.launchpad.net/bugs/1818815Signed-off-by: default avatarchenzefeng <chenzefeng2@huawei.com>

On x86-64, for 32-bit PC-relacive branches, we can generate PLT32
relocation, instead of PC32 relocation. and R_X86_64_PLT32 can be
treated the same as R_X86_64_PC32 since linux kernel doesn't use PLT.

commit b21ebf2f ("x86: Treat R_X86_64_PLT32 as R_X86_64_PC32") been
fixed for the module loading, but not fixed for livepatch relocation,
which will fail to load livepatch with the error message as follow:
relocation failed for symbol <symbol name> at <symbol address>

This issue only effacted the kernel version from 4.0 to 4.6, becauce the
function klp_write_module_reloc is introduced by: commit b700e7f0
("livepatch: kernel: add support for live patching") and deleted by:
commit 425595a7 ("livepatch: reuse module loader code to write
relocations")
Signed-off-by: default avatarchenzefeng <chenzefeng2@huawei.com>
Reviewed-by: default avatarPetr Mladek <pmladek@suse.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarJuerg Haefliger <juergh@canonical.com>
Signed-off-by: default avatarKhalid Elmously <khalid.elmously@canonical.com>
parent 2b059e5b
...@@ -55,6 +55,7 @@ int klp_write_module_reloc(struct module *mod, unsigned long type, ...@@ -55,6 +55,7 @@ int klp_write_module_reloc(struct module *mod, unsigned long type,
val = (s32)value; val = (s32)value;
break; break;
case R_X86_64_PC32: case R_X86_64_PC32:
case R_X86_64_PLT32:
val = (u32)(value - loc); val = (u32)(value - loc);
break; break;
default: default:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment