Commit 3114cdfe authored by Alexander Duyck's avatar Alexander Duyck Committed by David S. Miller

ipv4: Fix memory leak in exception case for splitting tries

Fix a small memory leak that can occur where we leak a fib_alias in the
event of us not being able to insert it into the local table.

Fixes: 0ddcf43d ("ipv4: FIB Local/MAIN table collapse")
Reported-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarAlexander Duyck <alexander.h.duyck@intel.com>
Acked-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3b709334
...@@ -1743,8 +1743,10 @@ struct fib_table *fib_trie_unmerge(struct fib_table *oldtb) ...@@ -1743,8 +1743,10 @@ struct fib_table *fib_trie_unmerge(struct fib_table *oldtb)
local_l = fib_find_node(lt, &local_tp, l->key); local_l = fib_find_node(lt, &local_tp, l->key);
if (fib_insert_alias(lt, local_tp, local_l, new_fa, if (fib_insert_alias(lt, local_tp, local_l, new_fa,
NULL, l->key)) NULL, l->key)) {
kmem_cache_free(fn_alias_kmem, new_fa);
goto out; goto out;
}
} }
/* stop loop if key wrapped back to 0 */ /* stop loop if key wrapped back to 0 */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment