Commit 31d0d4e0 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Vinod Koul

phy: st: phy-stm32-usbphyc: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230307115900.2293120-24-u.kleine-koenig@pengutronix.deSigned-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 1d558e55
...@@ -766,7 +766,7 @@ static int stm32_usbphyc_probe(struct platform_device *pdev) ...@@ -766,7 +766,7 @@ static int stm32_usbphyc_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int stm32_usbphyc_remove(struct platform_device *pdev) static void stm32_usbphyc_remove(struct platform_device *pdev)
{ {
struct stm32_usbphyc *usbphyc = dev_get_drvdata(&pdev->dev); struct stm32_usbphyc *usbphyc = dev_get_drvdata(&pdev->dev);
int port; int port;
...@@ -779,8 +779,6 @@ static int stm32_usbphyc_remove(struct platform_device *pdev) ...@@ -779,8 +779,6 @@ static int stm32_usbphyc_remove(struct platform_device *pdev)
stm32_usbphyc_clk48_unregister(usbphyc); stm32_usbphyc_clk48_unregister(usbphyc);
clk_disable_unprepare(usbphyc->clk); clk_disable_unprepare(usbphyc->clk);
return 0;
} }
static int __maybe_unused stm32_usbphyc_resume(struct device *dev) static int __maybe_unused stm32_usbphyc_resume(struct device *dev)
...@@ -810,7 +808,7 @@ MODULE_DEVICE_TABLE(of, stm32_usbphyc_of_match); ...@@ -810,7 +808,7 @@ MODULE_DEVICE_TABLE(of, stm32_usbphyc_of_match);
static struct platform_driver stm32_usbphyc_driver = { static struct platform_driver stm32_usbphyc_driver = {
.probe = stm32_usbphyc_probe, .probe = stm32_usbphyc_probe,
.remove = stm32_usbphyc_remove, .remove_new = stm32_usbphyc_remove,
.driver = { .driver = {
.of_match_table = stm32_usbphyc_of_match, .of_match_table = stm32_usbphyc_of_match,
.name = "stm32-usbphyc", .name = "stm32-usbphyc",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment