Commit 321275f0 authored by Nishka Dasgupta's avatar Nishka Dasgupta Committed by Marc Zyngier

irqchip/irq-mbigen: Add of_node_put() before return

Each iteration of for_each_child_of_node puts the previous node, but
in the case of a return from the middle of the loop, there is no put,
thus causing a memory leak. Add an of_node_put before the return in
three places.
Issue found with Coccinelle.
Signed-off-by: default avatarNishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
parent 34f8eb92
...@@ -252,12 +252,15 @@ static int mbigen_of_create_domain(struct platform_device *pdev, ...@@ -252,12 +252,15 @@ static int mbigen_of_create_domain(struct platform_device *pdev,
parent = platform_bus_type.dev_root; parent = platform_bus_type.dev_root;
child = of_platform_device_create(np, NULL, parent); child = of_platform_device_create(np, NULL, parent);
if (!child) if (!child) {
of_node_put(np);
return -ENOMEM; return -ENOMEM;
}
if (of_property_read_u32(child->dev.of_node, "num-pins", if (of_property_read_u32(child->dev.of_node, "num-pins",
&num_pins) < 0) { &num_pins) < 0) {
dev_err(&pdev->dev, "No num-pins property\n"); dev_err(&pdev->dev, "No num-pins property\n");
of_node_put(np);
return -EINVAL; return -EINVAL;
} }
...@@ -265,8 +268,10 @@ static int mbigen_of_create_domain(struct platform_device *pdev, ...@@ -265,8 +268,10 @@ static int mbigen_of_create_domain(struct platform_device *pdev,
mbigen_write_msg, mbigen_write_msg,
&mbigen_domain_ops, &mbigen_domain_ops,
mgn_chip); mgn_chip);
if (!domain) if (!domain) {
of_node_put(np);
return -ENOMEM; return -ENOMEM;
}
} }
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment