Commit 3337022b authored by Jakub Kicinski's avatar Jakub Kicinski

Merge branch 'net-renesas-rswitch-add-speed-change-support'

Yoshihiro Shimoda says:

====================
net: renesas: rswitch: Add speed change support

Add speed change support at runtime for the latest SoC version.
Also, add ethtool .[gs]et_link_ksettings.

v1: https://lore.kernel.org/all/20230803120621.1471440-1-yoshihiro.shimoda.uh@renesas.com/
====================

Link: https://lore.kernel.org/r/20230807003231.1552062-1-yoshihiro.shimoda.uh@renesas.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parents f1d152eb 20f8be6b
...@@ -20,6 +20,7 @@ ...@@ -20,6 +20,7 @@
#include <linux/rtnetlink.h> #include <linux/rtnetlink.h>
#include <linux/slab.h> #include <linux/slab.h>
#include <linux/spinlock.h> #include <linux/spinlock.h>
#include <linux/sys_soc.h>
#include "rswitch.h" #include "rswitch.h"
...@@ -1243,7 +1244,6 @@ static void rswitch_adjust_link(struct net_device *ndev) ...@@ -1243,7 +1244,6 @@ static void rswitch_adjust_link(struct net_device *ndev)
struct rswitch_device *rdev = netdev_priv(ndev); struct rswitch_device *rdev = netdev_priv(ndev);
struct phy_device *phydev = ndev->phydev; struct phy_device *phydev = ndev->phydev;
/* Current hardware has a restriction not to change speed at runtime */
if (phydev->link != rdev->etha->link) { if (phydev->link != rdev->etha->link) {
phy_print_status(phydev); phy_print_status(phydev);
if (phydev->link) if (phydev->link)
...@@ -1252,13 +1252,23 @@ static void rswitch_adjust_link(struct net_device *ndev) ...@@ -1252,13 +1252,23 @@ static void rswitch_adjust_link(struct net_device *ndev)
phy_power_off(rdev->serdes); phy_power_off(rdev->serdes);
rdev->etha->link = phydev->link; rdev->etha->link = phydev->link;
if (!rdev->priv->etha_no_runtime_change &&
phydev->speed != rdev->etha->speed) {
rdev->etha->speed = phydev->speed;
rswitch_etha_hw_init(rdev->etha, rdev->ndev->dev_addr);
phy_set_speed(rdev->serdes, rdev->etha->speed);
}
} }
} }
static void rswitch_phy_remove_link_mode(struct rswitch_device *rdev, static void rswitch_phy_remove_link_mode(struct rswitch_device *rdev,
struct phy_device *phydev) struct phy_device *phydev)
{ {
/* Current hardware has a restriction not to change speed at runtime */ if (!rdev->priv->etha_no_runtime_change)
return;
switch (rdev->etha->speed) { switch (rdev->etha->speed) {
case SPEED_2500: case SPEED_2500:
phy_remove_link_mode(phydev, ETHTOOL_LINK_MODE_1000baseT_Full_BIT); phy_remove_link_mode(phydev, ETHTOOL_LINK_MODE_1000baseT_Full_BIT);
...@@ -1347,7 +1357,8 @@ static int rswitch_ether_port_init_one(struct rswitch_device *rdev) ...@@ -1347,7 +1357,8 @@ static int rswitch_ether_port_init_one(struct rswitch_device *rdev)
err = rswitch_etha_hw_init(rdev->etha, rdev->ndev->dev_addr); err = rswitch_etha_hw_init(rdev->etha, rdev->ndev->dev_addr);
if (err < 0) if (err < 0)
return err; return err;
rdev->etha->operated = true; if (rdev->priv->etha_no_runtime_change)
rdev->etha->operated = true;
} }
err = rswitch_mii_register(rdev); err = rswitch_mii_register(rdev);
...@@ -1653,6 +1664,8 @@ static int rswitch_get_ts_info(struct net_device *ndev, struct ethtool_ts_info * ...@@ -1653,6 +1664,8 @@ static int rswitch_get_ts_info(struct net_device *ndev, struct ethtool_ts_info *
static const struct ethtool_ops rswitch_ethtool_ops = { static const struct ethtool_ops rswitch_ethtool_ops = {
.get_ts_info = rswitch_get_ts_info, .get_ts_info = rswitch_get_ts_info,
.get_link_ksettings = phy_ethtool_get_link_ksettings,
.set_link_ksettings = phy_ethtool_set_link_ksettings,
}; };
static const struct of_device_id renesas_eth_sw_of_table[] = { static const struct of_device_id renesas_eth_sw_of_table[] = {
...@@ -1853,8 +1866,14 @@ static int rswitch_init(struct rswitch_private *priv) ...@@ -1853,8 +1866,14 @@ static int rswitch_init(struct rswitch_private *priv)
return err; return err;
} }
static const struct soc_device_attribute rswitch_soc_no_speed_change[] = {
{ .soc_id = "r8a779f0", .revision = "ES1.0" },
{ /* Sentinel */ }
};
static int renesas_eth_sw_probe(struct platform_device *pdev) static int renesas_eth_sw_probe(struct platform_device *pdev)
{ {
const struct soc_device_attribute *attr;
struct rswitch_private *priv; struct rswitch_private *priv;
struct resource *res; struct resource *res;
int ret; int ret;
...@@ -1869,6 +1888,10 @@ static int renesas_eth_sw_probe(struct platform_device *pdev) ...@@ -1869,6 +1888,10 @@ static int renesas_eth_sw_probe(struct platform_device *pdev)
if (!priv) if (!priv)
return -ENOMEM; return -ENOMEM;
attr = soc_device_match(rswitch_soc_no_speed_change);
if (attr)
priv->etha_no_runtime_change = true;
priv->ptp_priv = rcar_gen4_ptp_alloc(pdev); priv->ptp_priv = rcar_gen4_ptp_alloc(pdev);
if (!priv->ptp_priv) if (!priv->ptp_priv)
return -ENOMEM; return -ENOMEM;
......
...@@ -1011,6 +1011,7 @@ struct rswitch_private { ...@@ -1011,6 +1011,7 @@ struct rswitch_private {
struct rswitch_etha etha[RSWITCH_NUM_PORTS]; struct rswitch_etha etha[RSWITCH_NUM_PORTS];
struct rswitch_mfwd mfwd; struct rswitch_mfwd mfwd;
bool etha_no_runtime_change;
bool gwca_halt; bool gwca_halt;
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment