Commit 334f5b61 authored by Wenwen Wang's avatar Wenwen Wang Committed by Kalle Valo

ath10k: add cleanup in ath10k_sta_state()

If 'sta->tdls' is false, no cleanup is executed, leading to memory/resource
leaks, e.g., 'arsta->tx_stats'. To fix this issue, perform cleanup before
go to the 'exit' label.
Signed-off-by: default avatarWenwen Wang <wenwen@cs.uga.edu>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent c4130599
...@@ -6559,8 +6559,12 @@ static int ath10k_sta_state(struct ieee80211_hw *hw, ...@@ -6559,8 +6559,12 @@ static int ath10k_sta_state(struct ieee80211_hw *hw,
spin_unlock_bh(&ar->data_lock); spin_unlock_bh(&ar->data_lock);
if (!sta->tdls) if (!sta->tdls) {
ath10k_peer_delete(ar, arvif->vdev_id, sta->addr);
ath10k_mac_dec_num_stations(arvif, sta);
kfree(arsta->tx_stats);
goto exit; goto exit;
}
ret = ath10k_wmi_update_fw_tdls_state(ar, arvif->vdev_id, ret = ath10k_wmi_update_fw_tdls_state(ar, arvif->vdev_id,
WMI_TDLS_ENABLE_ACTIVE); WMI_TDLS_ENABLE_ACTIVE);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment