Commit 35931eb3 authored by Matthew Wilcox (Oracle)'s avatar Matthew Wilcox (Oracle) Committed by Christian Brauner

fs: Fix kernel-doc warnings

These have a variety of causes and a corresponding variety of solutions.
Signed-off-by: default avatar"Matthew Wilcox (Oracle)" <willy@infradead.org>
Message-Id: <20230818200824.2720007-1-willy@infradead.org>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent ec05b126
...@@ -668,7 +668,7 @@ EXPORT_SYMBOL(close_fd); /* for ksys_close() */ ...@@ -668,7 +668,7 @@ EXPORT_SYMBOL(close_fd); /* for ksys_close() */
/** /**
* last_fd - return last valid index into fd table * last_fd - return last valid index into fd table
* @cur_fds: files struct * @fdt: File descriptor table.
* *
* Context: Either rcu read lock or files_lock must be held. * Context: Either rcu read lock or files_lock must be held.
* *
...@@ -724,6 +724,7 @@ static inline void __range_close(struct files_struct *files, unsigned int fd, ...@@ -724,6 +724,7 @@ static inline void __range_close(struct files_struct *files, unsigned int fd,
* *
* @fd: starting file descriptor to close * @fd: starting file descriptor to close
* @max_fd: last file descriptor to close * @max_fd: last file descriptor to close
* @flags: CLOSE_RANGE flags.
* *
* This closes a range of file descriptors. All file descriptors * This closes a range of file descriptors. All file descriptors
* from @fd up to and including @max_fd are closed. * from @fd up to and including @max_fd are closed.
......
...@@ -162,6 +162,10 @@ EXPORT_SYMBOL(vfs_parse_fs_param); ...@@ -162,6 +162,10 @@ EXPORT_SYMBOL(vfs_parse_fs_param);
/** /**
* vfs_parse_fs_string - Convenience function to just parse a string. * vfs_parse_fs_string - Convenience function to just parse a string.
* @fc: Filesystem context.
* @key: Parameter name.
* @value: Default value.
* @v_size: Maximum number of bytes in the value.
*/ */
int vfs_parse_fs_string(struct fs_context *fc, const char *key, int vfs_parse_fs_string(struct fs_context *fc, const char *key,
const char *value, size_t v_size) const char *value, size_t v_size)
...@@ -189,7 +193,7 @@ EXPORT_SYMBOL(vfs_parse_fs_string); ...@@ -189,7 +193,7 @@ EXPORT_SYMBOL(vfs_parse_fs_string);
/** /**
* generic_parse_monolithic - Parse key[=val][,key[=val]]* mount data * generic_parse_monolithic - Parse key[=val][,key[=val]]* mount data
* @ctx: The superblock configuration to fill in. * @fc: The superblock configuration to fill in.
* @data: The data to parse * @data: The data to parse
* *
* Parse a blob of data that's in key[=val][,key[=val]]* form. This can be * Parse a blob of data that's in key[=val][,key[=val]]* form. This can be
...@@ -354,7 +358,7 @@ void fc_drop_locked(struct fs_context *fc) ...@@ -354,7 +358,7 @@ void fc_drop_locked(struct fs_context *fc)
static void legacy_fs_context_free(struct fs_context *fc); static void legacy_fs_context_free(struct fs_context *fc);
/** /**
* vfs_dup_fc_config: Duplicate a filesystem context. * vfs_dup_fs_context - Duplicate a filesystem context.
* @src_fc: The context to copy. * @src_fc: The context to copy.
*/ */
struct fs_context *vfs_dup_fs_context(struct fs_context *src_fc) struct fs_context *vfs_dup_fs_context(struct fs_context *src_fc)
...@@ -400,7 +404,9 @@ EXPORT_SYMBOL(vfs_dup_fs_context); ...@@ -400,7 +404,9 @@ EXPORT_SYMBOL(vfs_dup_fs_context);
/** /**
* logfc - Log a message to a filesystem context * logfc - Log a message to a filesystem context
* @fc: The filesystem context to log to. * @log: The filesystem context to log to, or NULL to use printk.
* @prefix: A string to prefix the output with, or NULL.
* @level: 'w' for a warning, 'e' for an error. Anything else is a notice.
* @fmt: The format of the buffer. * @fmt: The format of the buffer.
*/ */
void logfc(struct fc_log *log, const char *prefix, char level, const char *fmt, ...) void logfc(struct fc_log *log, const char *prefix, char level, const char *fmt, ...)
......
...@@ -109,9 +109,6 @@ static int ioctl_fibmap(struct file *filp, int __user *p) ...@@ -109,9 +109,6 @@ static int ioctl_fibmap(struct file *filp, int __user *p)
* Returns 0 on success, -errno on error, 1 if this was the last * Returns 0 on success, -errno on error, 1 if this was the last
* extent that will fit in user array. * extent that will fit in user array.
*/ */
#define SET_UNKNOWN_FLAGS (FIEMAP_EXTENT_DELALLOC)
#define SET_NO_UNMOUNTED_IO_FLAGS (FIEMAP_EXTENT_DATA_ENCRYPTED)
#define SET_NOT_ALIGNED_FLAGS (FIEMAP_EXTENT_DATA_TAIL|FIEMAP_EXTENT_DATA_INLINE)
int fiemap_fill_next_extent(struct fiemap_extent_info *fieinfo, u64 logical, int fiemap_fill_next_extent(struct fiemap_extent_info *fieinfo, u64 logical,
u64 phys, u64 len, u32 flags) u64 phys, u64 len, u32 flags)
{ {
...@@ -127,6 +124,10 @@ int fiemap_fill_next_extent(struct fiemap_extent_info *fieinfo, u64 logical, ...@@ -127,6 +124,10 @@ int fiemap_fill_next_extent(struct fiemap_extent_info *fieinfo, u64 logical,
if (fieinfo->fi_extents_mapped >= fieinfo->fi_extents_max) if (fieinfo->fi_extents_mapped >= fieinfo->fi_extents_max)
return 1; return 1;
#define SET_UNKNOWN_FLAGS (FIEMAP_EXTENT_DELALLOC)
#define SET_NO_UNMOUNTED_IO_FLAGS (FIEMAP_EXTENT_DATA_ENCRYPTED)
#define SET_NOT_ALIGNED_FLAGS (FIEMAP_EXTENT_DATA_TAIL|FIEMAP_EXTENT_DATA_INLINE)
if (flags & SET_UNKNOWN_FLAGS) if (flags & SET_UNKNOWN_FLAGS)
flags |= FIEMAP_EXTENT_UNKNOWN; flags |= FIEMAP_EXTENT_UNKNOWN;
if (flags & SET_NO_UNMOUNTED_IO_FLAGS) if (flags & SET_NO_UNMOUNTED_IO_FLAGS)
...@@ -877,6 +878,9 @@ SYSCALL_DEFINE3(ioctl, unsigned int, fd, unsigned int, cmd, unsigned long, arg) ...@@ -877,6 +878,9 @@ SYSCALL_DEFINE3(ioctl, unsigned int, fd, unsigned int, cmd, unsigned long, arg)
#ifdef CONFIG_COMPAT #ifdef CONFIG_COMPAT
/** /**
* compat_ptr_ioctl - generic implementation of .compat_ioctl file operation * compat_ptr_ioctl - generic implementation of .compat_ioctl file operation
* @file: The file to operate on.
* @cmd: The ioctl command number.
* @arg: The argument to the ioctl.
* *
* This is not normally called as a function, but instead set in struct * This is not normally called as a function, but instead set in struct
* file_operations as * file_operations as
......
...@@ -8,16 +8,16 @@ ...@@ -8,16 +8,16 @@
/** /**
* kernel_read_file() - read file contents into a kernel buffer * kernel_read_file() - read file contents into a kernel buffer
* *
* @file file to read from * @file: file to read from
* @offset where to start reading from (see below). * @offset: where to start reading from (see below).
* @buf pointer to a "void *" buffer for reading into (if * @buf: pointer to a "void *" buffer for reading into (if
* *@buf is NULL, a buffer will be allocated, and * *@buf is NULL, a buffer will be allocated, and
* @buf_size will be ignored) * @buf_size will be ignored)
* @buf_size size of buf, if already allocated. If @buf not * @buf_size: size of buf, if already allocated. If @buf not
* allocated, this is the largest size to allocate. * allocated, this is the largest size to allocate.
* @file_size if non-NULL, the full size of @file will be * @file_size: if non-NULL, the full size of @file will be
* written here. * written here.
* @id the kernel_read_file_id identifying the type of * @id: the kernel_read_file_id identifying the type of
* file contents being read (for LSMs to examine) * file contents being read (for LSMs to examine)
* *
* @offset must be 0 unless both @buf and @file_size are non-NULL * @offset must be 0 unless both @buf and @file_size are non-NULL
......
...@@ -643,6 +643,8 @@ static bool nd_alloc_stack(struct nameidata *nd) ...@@ -643,6 +643,8 @@ static bool nd_alloc_stack(struct nameidata *nd)
/** /**
* path_connected - Verify that a dentry is below mnt.mnt_root * path_connected - Verify that a dentry is below mnt.mnt_root
* @mnt: The mountpoint to check.
* @dentry: The dentry to check.
* *
* Rename can sometimes move a file or directory outside of a bind * Rename can sometimes move a file or directory outside of a bind
* mount, path_connected allows those cases to be detected. * mount, path_connected allows those cases to be detected.
...@@ -1083,6 +1085,7 @@ fs_initcall(init_fs_namei_sysctls); ...@@ -1083,6 +1085,7 @@ fs_initcall(init_fs_namei_sysctls);
/** /**
* may_follow_link - Check symlink following for unsafe situations * may_follow_link - Check symlink following for unsafe situations
* @nd: nameidata pathwalk data * @nd: nameidata pathwalk data
* @inode: Used for idmapping.
* *
* In the case of the sysctl_protected_symlinks sysctl being enabled, * In the case of the sysctl_protected_symlinks sysctl being enabled,
* CAP_DAC_OVERRIDE needs to be specifically ignored if the symlink is * CAP_DAC_OVERRIDE needs to be specifically ignored if the symlink is
......
...@@ -1150,7 +1150,7 @@ EXPORT_SYMBOL_GPL(kernel_file_open); ...@@ -1150,7 +1150,7 @@ EXPORT_SYMBOL_GPL(kernel_file_open);
* backing_file_open - open a backing file for kernel internal use * backing_file_open - open a backing file for kernel internal use
* @path: path of the file to open * @path: path of the file to open
* @flags: open flags * @flags: open flags
* @path: path of the backing file * @real_path: path of the backing file
* @cred: credentials for open * @cred: credentials for open
* *
* Open a backing file for a stackable filesystem (e.g., overlayfs). * Open a backing file for a stackable filesystem (e.g., overlayfs).
...@@ -1567,7 +1567,7 @@ SYSCALL_DEFINE1(close, unsigned int, fd) ...@@ -1567,7 +1567,7 @@ SYSCALL_DEFINE1(close, unsigned int, fd)
} }
/** /**
* close_range() - Close all file descriptors in a given range. * sys_close_range() - Close all file descriptors in a given range.
* *
* @fd: starting file descriptor to close * @fd: starting file descriptor to close
* @max_fd: last file descriptor to close * @max_fd: last file descriptor to close
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment