Commit 36690325 authored by Cristian Marussi's avatar Cristian Marussi Committed by Sudeep Holla

firmware: arm_scmi: Remove scmi_dump_header_dbg() helper

Being a while that we have SCMI trace events in the SCMI stack, remove
this debug helper and its call sites.

Link: https://lore.kernel.org/r/20210803131024.40280-3-cristian.marussi@arm.comSigned-off-by: default avatarCristian Marussi <cristian.marussi@arm.com>
Signed-off-by: default avatarSudeep Holla <sudeep.holla@arm.com>
parent 63b282f1
...@@ -172,19 +172,6 @@ static inline int scmi_to_linux_errno(int errno) ...@@ -172,19 +172,6 @@ static inline int scmi_to_linux_errno(int errno)
return -EIO; return -EIO;
} }
/**
* scmi_dump_header_dbg() - Helper to dump a message header.
*
* @dev: Device pointer corresponding to the SCMI entity
* @hdr: pointer to header.
*/
static inline void scmi_dump_header_dbg(struct device *dev,
struct scmi_msg_hdr *hdr)
{
dev_dbg(dev, "Message ID: %x Sequence ID: %x Protocol: %x\n",
hdr->id, hdr->seq, hdr->protocol_id);
}
void scmi_notification_instance_data_set(const struct scmi_handle *handle, void scmi_notification_instance_data_set(const struct scmi_handle *handle,
void *priv) void *priv)
{ {
...@@ -288,7 +275,6 @@ static void scmi_handle_notification(struct scmi_chan_info *cinfo, u32 msg_hdr) ...@@ -288,7 +275,6 @@ static void scmi_handle_notification(struct scmi_chan_info *cinfo, u32 msg_hdr)
} }
unpack_scmi_header(msg_hdr, &xfer->hdr); unpack_scmi_header(msg_hdr, &xfer->hdr);
scmi_dump_header_dbg(dev, &xfer->hdr);
info->desc->ops->fetch_notification(cinfo, info->desc->max_msg_size, info->desc->ops->fetch_notification(cinfo, info->desc->max_msg_size,
xfer); xfer);
scmi_notify(cinfo->handle, xfer->hdr.protocol_id, scmi_notify(cinfo->handle, xfer->hdr.protocol_id,
...@@ -339,8 +325,6 @@ static void scmi_handle_response(struct scmi_chan_info *cinfo, ...@@ -339,8 +325,6 @@ static void scmi_handle_response(struct scmi_chan_info *cinfo,
if (msg_type == MSG_TYPE_DELAYED_RESP) if (msg_type == MSG_TYPE_DELAYED_RESP)
xfer->rx.len = info->desc->max_msg_size; xfer->rx.len = info->desc->max_msg_size;
scmi_dump_header_dbg(dev, &xfer->hdr);
info->desc->ops->fetch_response(cinfo, xfer); info->desc->ops->fetch_response(cinfo, xfer);
trace_scmi_rx_done(xfer->transfer_id, xfer->hdr.id, trace_scmi_rx_done(xfer->transfer_id, xfer->hdr.id,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment