Commit 378193ef authored by Jakub Kicinski's avatar Jakub Kicinski Committed by David S. Miller

selftests: kselftest_harness: let PASS / FAIL provide diagnostic

Switch to printing KTAP line for PASS / FAIL with ksft_test_result_code(),
this gives us the ability to report diagnostic messages.
Reviewed-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 42ab727e
...@@ -1143,14 +1143,13 @@ void __run_test(struct __fixture_metadata *f, ...@@ -1143,14 +1143,13 @@ void __run_test(struct __fixture_metadata *f,
if (t->results->reason[0]) if (t->results->reason[0])
diagnostic = t->results->reason; diagnostic = t->results->reason;
else if (t->exit_code == KSFT_PASS || t->exit_code == KSFT_FAIL)
diagnostic = NULL;
else else
diagnostic = "unknown"; diagnostic = "unknown";
if (t->exit_code == KSFT_SKIP) ksft_test_result_code(t->exit_code, test_name,
ksft_test_result_code(t->exit_code, test_name, diagnostic ? "%s" : "", diagnostic);
"%s", diagnostic);
else
ksft_test_result(__test_passed(t), "%s\n", test_name);
} }
static int test_harness_run(int argc, char **argv) static int test_harness_run(int argc, char **argv)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment