Commit 388e6f0d authored by Vojtech Pavlik's avatar Vojtech Pavlik

input: Fix poll() behavior of input handlers on disconnect.

Signed-off-by: default avatarVojtech Pavlik <vojtech@suse.cz>
parent 113fc8b3
......@@ -199,9 +199,8 @@ static unsigned int evdev_poll(struct file *file, poll_table *wait)
{
struct evdev_list *list = file->private_data;
poll_wait(file, &list->evdev->wait, wait);
if (list->head != list->tail)
return POLLIN | POLLRDNORM;
return 0;
return ((list->head == list->tail) ? 0 : (POLLIN | POLLRDNORM)) |
(list->evdev->exist ? 0 : (POLLHUP | POLLERR));
}
static int evdev_ioctl(struct inode *inode, struct file *file, unsigned int cmd, unsigned long arg)
......
......@@ -281,9 +281,8 @@ static unsigned int joydev_poll(struct file *file, poll_table *wait)
{
struct joydev_list *list = file->private_data;
poll_wait(file, &list->joydev->wait, wait);
if (list->head != list->tail || list->startup < list->joydev->nabs + list->joydev->nkey)
return POLLIN | POLLRDNORM;
return 0;
return ((list->head != list->tail || list->startup < list->joydev->nabs + list->joydev->nkey) ?
(POLLIN | POLLRDNORM) : 0) | (list->joydev->exist ? 0 : (POLLHUP | POLLERR));
}
static int joydev_ioctl(struct inode *inode, struct file *file, unsigned int cmd, unsigned long arg)
......@@ -468,9 +467,10 @@ static void joydev_disconnect(struct input_handle *handle)
devfs_remove("input/js%d", joydev->minor);
joydev->exist = 0;
if (joydev->open)
if (joydev->open) {
input_close_device(handle);
else
wake_up_interruptible(&joydev->wait);
} else
joydev_free(joydev);
}
......
......@@ -595,9 +595,8 @@ static unsigned int mousedev_poll(struct file *file, poll_table *wait)
{
struct mousedev_list *list = file->private_data;
poll_wait(file, &list->mousedev->wait, wait);
if (list->ready || list->buffer)
return POLLIN | POLLRDNORM;
return 0;
return ((list->ready || list->buffer) ? (POLLIN | POLLRDNORM) : 0) |
(list->mousedev->exist ? 0 : (POLLHUP | POLLERR));
}
static struct file_operations mousedev_fops = {
......@@ -660,6 +659,7 @@ static void mousedev_disconnect(struct input_handle *handle)
if (mousedev->open) {
input_close_device(handle);
wake_up_interruptible(&mousedev->wait);
} else {
if (mousedev_mix.open)
input_close_device(handle);
......
......@@ -232,11 +232,9 @@ static ssize_t tsdev_read(struct file *file, char __user *buffer, size_t count,
static unsigned int tsdev_poll(struct file *file, poll_table * wait)
{
struct tsdev_list *list = file->private_data;
poll_wait(file, &list->tsdev->wait, wait);
if (list->head != list->tail)
return POLLIN | POLLRDNORM;
return 0;
return ((list->head == list->tail) ? 0 : (POLLIN | POLLRDNORM)) |
(list->tsdev->exist ? 0 : (POLLHUP | POLLERR));
}
static int tsdev_ioctl(struct inode *inode, struct file *file,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment