Commit 38bdb650 authored by Felix Fietkau's avatar Felix Fietkau Committed by John W. Linville

mac80211: fix the for_each_sta_info macro

Because of an ambiguity in the for_each_sta_info macro, it can
currently only be used if the third parameter is set to 'sta'.
Fix this by renaming the parameter to '_sta'.
Signed-off-by: default avatarFelix Fietkau <nbd@openwrt.org>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 78c4653a
...@@ -427,20 +427,20 @@ void for_each_sta_info_type_check(struct ieee80211_local *local, ...@@ -427,20 +427,20 @@ void for_each_sta_info_type_check(struct ieee80211_local *local,
{ {
} }
#define for_each_sta_info(local, _addr, sta, nxt) \ #define for_each_sta_info(local, _addr, _sta, nxt) \
for ( /* initialise loop */ \ for ( /* initialise loop */ \
sta = rcu_dereference(local->sta_hash[STA_HASH(_addr)]),\ _sta = rcu_dereference(local->sta_hash[STA_HASH(_addr)]),\
nxt = sta ? rcu_dereference(sta->hnext) : NULL; \ nxt = _sta ? rcu_dereference(_sta->hnext) : NULL; \
/* typecheck */ \ /* typecheck */ \
for_each_sta_info_type_check(local, (_addr), sta, nxt), \ for_each_sta_info_type_check(local, (_addr), _sta, nxt),\
/* continue condition */ \ /* continue condition */ \
sta; \ _sta; \
/* advance loop */ \ /* advance loop */ \
sta = nxt, \ _sta = nxt, \
nxt = sta ? rcu_dereference(sta->hnext) : NULL \ nxt = _sta ? rcu_dereference(_sta->hnext) : NULL \
) \ ) \
/* compare address and run code only if it matches */ \ /* compare address and run code only if it matches */ \
if (memcmp(sta->sta.addr, (_addr), ETH_ALEN) == 0) if (memcmp(_sta->sta.addr, (_addr), ETH_ALEN) == 0)
/* /*
* Get STA info by index, BROKEN! * Get STA info by index, BROKEN!
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment