Commit 395166a4 authored by Axel Lin's avatar Axel Lin Committed by Ben Hutchings

hwmon: (ads1015) Fix off-by-one for valid channel index checking

commit 56de1377 upstream.

Current code uses channel as array index, so the valid channel value is
0 .. ADS1015_CHANNELS - 1.
Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
parent 0f7e814c
...@@ -186,7 +186,7 @@ static int ads1015_get_channels_config_of(struct i2c_client *client) ...@@ -186,7 +186,7 @@ static int ads1015_get_channels_config_of(struct i2c_client *client)
} }
channel = be32_to_cpup(property); channel = be32_to_cpup(property);
if (channel > ADS1015_CHANNELS) { if (channel >= ADS1015_CHANNELS) {
dev_err(&client->dev, dev_err(&client->dev,
"invalid channel index %d on %s\n", "invalid channel index %d on %s\n",
channel, node->full_name); channel, node->full_name);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment