Commit 39797753 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Guenter Roeck

hwmon: (sis5595) Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230918085951.1234172-17-u.kleine-koenig@pengutronix.deSigned-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent a93a2c41
...@@ -709,7 +709,7 @@ static int sis5595_probe(struct platform_device *pdev) ...@@ -709,7 +709,7 @@ static int sis5595_probe(struct platform_device *pdev)
return err; return err;
} }
static int sis5595_remove(struct platform_device *pdev) static void sis5595_remove(struct platform_device *pdev)
{ {
struct sis5595_data *data = platform_get_drvdata(pdev); struct sis5595_data *data = platform_get_drvdata(pdev);
...@@ -717,8 +717,6 @@ static int sis5595_remove(struct platform_device *pdev) ...@@ -717,8 +717,6 @@ static int sis5595_remove(struct platform_device *pdev)
sysfs_remove_group(&pdev->dev.kobj, &sis5595_group); sysfs_remove_group(&pdev->dev.kobj, &sis5595_group);
sysfs_remove_group(&pdev->dev.kobj, &sis5595_group_in4); sysfs_remove_group(&pdev->dev.kobj, &sis5595_group_in4);
sysfs_remove_group(&pdev->dev.kobj, &sis5595_group_temp1); sysfs_remove_group(&pdev->dev.kobj, &sis5595_group_temp1);
return 0;
} }
static const struct pci_device_id sis5595_pci_ids[] = { static const struct pci_device_id sis5595_pci_ids[] = {
...@@ -790,7 +788,7 @@ static struct platform_driver sis5595_driver = { ...@@ -790,7 +788,7 @@ static struct platform_driver sis5595_driver = {
.name = DRIVER_NAME, .name = DRIVER_NAME,
}, },
.probe = sis5595_probe, .probe = sis5595_probe,
.remove = sis5595_remove, .remove_new = sis5595_remove,
}; };
static int sis5595_pci_probe(struct pci_dev *dev, static int sis5595_pci_probe(struct pci_dev *dev,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment