Commit 39815141 authored by Jim Wylder's avatar Jim Wylder Committed by Mark Brown

regmap: Account for register length when chunking

Currently, when regmap_raw_write() splits the data, it uses the
max_raw_write value defined for the bus.  For any bus that includes
the target register address in the max_raw_write value, the chunked
transmission will always exceed the maximum transmission length.
To avoid this problem, subtract the length of the register and the
padding from the maximum transmission.

Signed-off-by: Jim Wylder <jwylder@google.com
Link: https://lore.kernel.org/r/20230517152444.3690870-2-jwylder@google.com
Signed-off-by: Mark Brown <broonie@kernel.org
parent 70a640c0
...@@ -2082,6 +2082,8 @@ int _regmap_raw_write(struct regmap *map, unsigned int reg, ...@@ -2082,6 +2082,8 @@ int _regmap_raw_write(struct regmap *map, unsigned int reg,
size_t val_count = val_len / val_bytes; size_t val_count = val_len / val_bytes;
size_t chunk_count, chunk_bytes; size_t chunk_count, chunk_bytes;
size_t chunk_regs = val_count; size_t chunk_regs = val_count;
size_t max_data = map->max_raw_write - map->format.reg_bytes -
map->format.pad_bytes;
int ret, i; int ret, i;
if (!val_count) if (!val_count)
...@@ -2089,8 +2091,8 @@ int _regmap_raw_write(struct regmap *map, unsigned int reg, ...@@ -2089,8 +2091,8 @@ int _regmap_raw_write(struct regmap *map, unsigned int reg,
if (map->use_single_write) if (map->use_single_write)
chunk_regs = 1; chunk_regs = 1;
else if (map->max_raw_write && val_len > map->max_raw_write) else if (map->max_raw_write && val_len > max_data)
chunk_regs = map->max_raw_write / val_bytes; chunk_regs = max_data / val_bytes;
chunk_count = val_count / chunk_regs; chunk_count = val_count / chunk_regs;
chunk_bytes = chunk_regs * val_bytes; chunk_bytes = chunk_regs * val_bytes;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment