Commit 39a123c5 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Bjorn Andersson

arm64: dts: qcom: msm8998-oneplus: correct UFS pad supply

The Qualcomm UFS phy switched from dedicated driver to QMP phy driver.
Eventually the old driver was removed in commit 02dca8c9 ("phy:
qcom: remove ufs qmp phy driver").  The original driver and its binding
used vddp-ref-clk regulator supply, but the new one did not and left the
supply unused.

The Qualcomm UFS phy bindings were also migrated to newer ones and
dropped support for vddp-ref-clk regulator in commit dc5cb635
("dt-bindings: phy: migrate QMP UFS PHY bindings to
qcom,sc8280xp-qmp-ufs-phy.yaml").

It turns out that this regulator, although with inaccurate name
vddp-ref-clk, is actually needed to provide supply for VDD_PX10 (or
similar, depending on the SoC) used by UFS controller.

Bring back handling of this supply by using more appropriate regulator -
UFS controller host supply.  This also fixes dtbs_check warning:

  msm8998-oneplus-dumpling.dtb: phy@1da7000: 'vddp-ref-clk-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: default avatarKonrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/20230905161920.252013-11-krzysztof.kozlowski@linaro.orgSigned-off-by: default avatarBjorn Andersson <andersson@kernel.org>
parent e699305f
...@@ -534,6 +534,7 @@ &ufshc { ...@@ -534,6 +534,7 @@ &ufshc {
vcc-supply = <&vreg_l20a_2p95>; vcc-supply = <&vreg_l20a_2p95>;
vccq-supply = <&vreg_l26a_1p2>; vccq-supply = <&vreg_l26a_1p2>;
vccq2-supply = <&vreg_s4a_1p8>; vccq2-supply = <&vreg_s4a_1p8>;
vdd-hba-supply = <&vreg_l26a_1p2>;
vcc-max-microamp = <750000>; vcc-max-microamp = <750000>;
vccq-max-microamp = <560000>; vccq-max-microamp = <560000>;
vccq2-max-microamp = <750000>; vccq2-max-microamp = <750000>;
...@@ -544,7 +545,6 @@ &ufsphy { ...@@ -544,7 +545,6 @@ &ufsphy {
vdda-phy-supply = <&vreg_l1a_0p875>; vdda-phy-supply = <&vreg_l1a_0p875>;
vdda-pll-supply = <&vreg_l2a_1p2>; vdda-pll-supply = <&vreg_l2a_1p2>;
vddp-ref-clk-supply = <&vreg_l26a_1p2>;
}; };
&usb3 { &usb3 {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment