Commit 39d8cda7 authored by Pavel Emelyanov's avatar Pavel Emelyanov Committed by David S. Miller

[SOCK]: Add udp_hash member to struct proto.

Inspired by the commit ab1e0a13 ([SOCK] proto: Add hashinfo member to 
struct proto) from Arnaldo, I made similar thing for UDP/-Lite IPv4 
and -v6 protocols.

The result is not that exciting, but it removes some levels of
indirection in udpxxx_get_port and saves some space in code and text.

The first step is to union existing hashinfo and new udp_hash on the
struct proto and give a name to this union, since future initialization 
of tcpxxx_prot, dccp_vx_protinfo and udpxxx_protinfo will cause gcc 
warning about inability to initialize anonymous member this way.
Signed-off-by: default avatarPavel Emelyanov <xemul@openvz.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 22aba383
...@@ -223,7 +223,7 @@ static inline int inet_sk_listen_hashfn(const struct sock *sk) ...@@ -223,7 +223,7 @@ static inline int inet_sk_listen_hashfn(const struct sock *sk)
/* Caller must disable local BH processing. */ /* Caller must disable local BH processing. */
static inline void __inet_inherit_port(struct sock *sk, struct sock *child) static inline void __inet_inherit_port(struct sock *sk, struct sock *child)
{ {
struct inet_hashinfo *table = sk->sk_prot->hashinfo; struct inet_hashinfo *table = sk->sk_prot->h.hashinfo;
const int bhash = inet_bhashfn(inet_sk(child)->num, table->bhash_size); const int bhash = inet_bhashfn(inet_sk(child)->num, table->bhash_size);
struct inet_bind_hashbucket *head = &table->bhash[bhash]; struct inet_bind_hashbucket *head = &table->bhash[bhash];
struct inet_bind_bucket *tb; struct inet_bind_bucket *tb;
......
...@@ -586,7 +586,10 @@ struct proto { ...@@ -586,7 +586,10 @@ struct proto {
struct request_sock_ops *rsk_prot; struct request_sock_ops *rsk_prot;
struct timewait_sock_ops *twsk_prot; struct timewait_sock_ops *twsk_prot;
struct inet_hashinfo *hashinfo; union {
struct inet_hashinfo *hashinfo;
struct hlist_head *udp_hash;
} h;
struct module *owner; struct module *owner;
......
...@@ -941,7 +941,7 @@ static struct proto dccp_v4_prot = { ...@@ -941,7 +941,7 @@ static struct proto dccp_v4_prot = {
.obj_size = sizeof(struct dccp_sock), .obj_size = sizeof(struct dccp_sock),
.rsk_prot = &dccp_request_sock_ops, .rsk_prot = &dccp_request_sock_ops,
.twsk_prot = &dccp_timewait_sock_ops, .twsk_prot = &dccp_timewait_sock_ops,
.hashinfo = &dccp_hashinfo, .h.hashinfo = &dccp_hashinfo,
#ifdef CONFIG_COMPAT #ifdef CONFIG_COMPAT
.compat_setsockopt = compat_dccp_setsockopt, .compat_setsockopt = compat_dccp_setsockopt,
.compat_getsockopt = compat_dccp_getsockopt, .compat_getsockopt = compat_dccp_getsockopt,
......
...@@ -1126,7 +1126,7 @@ static struct proto dccp_v6_prot = { ...@@ -1126,7 +1126,7 @@ static struct proto dccp_v6_prot = {
.obj_size = sizeof(struct dccp6_sock), .obj_size = sizeof(struct dccp6_sock),
.rsk_prot = &dccp6_request_sock_ops, .rsk_prot = &dccp6_request_sock_ops,
.twsk_prot = &dccp6_timewait_sock_ops, .twsk_prot = &dccp6_timewait_sock_ops,
.hashinfo = &dccp_hashinfo, .h.hashinfo = &dccp_hashinfo,
#ifdef CONFIG_COMPAT #ifdef CONFIG_COMPAT
.compat_setsockopt = compat_dccp_setsockopt, .compat_setsockopt = compat_dccp_setsockopt,
.compat_getsockopt = compat_dccp_getsockopt, .compat_getsockopt = compat_dccp_getsockopt,
......
...@@ -80,7 +80,7 @@ EXPORT_SYMBOL_GPL(inet_csk_bind_conflict); ...@@ -80,7 +80,7 @@ EXPORT_SYMBOL_GPL(inet_csk_bind_conflict);
*/ */
int inet_csk_get_port(struct sock *sk, unsigned short snum) int inet_csk_get_port(struct sock *sk, unsigned short snum)
{ {
struct inet_hashinfo *hashinfo = sk->sk_prot->hashinfo; struct inet_hashinfo *hashinfo = sk->sk_prot->h.hashinfo;
struct inet_bind_hashbucket *head; struct inet_bind_hashbucket *head;
struct hlist_node *node; struct hlist_node *node;
struct inet_bind_bucket *tb; struct inet_bind_bucket *tb;
......
...@@ -68,7 +68,7 @@ void inet_bind_hash(struct sock *sk, struct inet_bind_bucket *tb, ...@@ -68,7 +68,7 @@ void inet_bind_hash(struct sock *sk, struct inet_bind_bucket *tb,
*/ */
static void __inet_put_port(struct sock *sk) static void __inet_put_port(struct sock *sk)
{ {
struct inet_hashinfo *hashinfo = sk->sk_prot->hashinfo; struct inet_hashinfo *hashinfo = sk->sk_prot->h.hashinfo;
const int bhash = inet_bhashfn(inet_sk(sk)->num, hashinfo->bhash_size); const int bhash = inet_bhashfn(inet_sk(sk)->num, hashinfo->bhash_size);
struct inet_bind_hashbucket *head = &hashinfo->bhash[bhash]; struct inet_bind_hashbucket *head = &hashinfo->bhash[bhash];
struct inet_bind_bucket *tb; struct inet_bind_bucket *tb;
...@@ -318,7 +318,7 @@ static inline u32 inet_sk_port_offset(const struct sock *sk) ...@@ -318,7 +318,7 @@ static inline u32 inet_sk_port_offset(const struct sock *sk)
void __inet_hash_nolisten(struct sock *sk) void __inet_hash_nolisten(struct sock *sk)
{ {
struct inet_hashinfo *hashinfo = sk->sk_prot->hashinfo; struct inet_hashinfo *hashinfo = sk->sk_prot->h.hashinfo;
struct hlist_head *list; struct hlist_head *list;
rwlock_t *lock; rwlock_t *lock;
struct inet_ehash_bucket *head; struct inet_ehash_bucket *head;
...@@ -339,7 +339,7 @@ EXPORT_SYMBOL_GPL(__inet_hash_nolisten); ...@@ -339,7 +339,7 @@ EXPORT_SYMBOL_GPL(__inet_hash_nolisten);
static void __inet_hash(struct sock *sk) static void __inet_hash(struct sock *sk)
{ {
struct inet_hashinfo *hashinfo = sk->sk_prot->hashinfo; struct inet_hashinfo *hashinfo = sk->sk_prot->h.hashinfo;
struct hlist_head *list; struct hlist_head *list;
rwlock_t *lock; rwlock_t *lock;
...@@ -372,7 +372,7 @@ EXPORT_SYMBOL_GPL(inet_hash); ...@@ -372,7 +372,7 @@ EXPORT_SYMBOL_GPL(inet_hash);
void inet_unhash(struct sock *sk) void inet_unhash(struct sock *sk)
{ {
rwlock_t *lock; rwlock_t *lock;
struct inet_hashinfo *hashinfo = sk->sk_prot->hashinfo; struct inet_hashinfo *hashinfo = sk->sk_prot->h.hashinfo;
if (sk_unhashed(sk)) if (sk_unhashed(sk))
goto out; goto out;
......
...@@ -2468,7 +2468,7 @@ struct proto tcp_prot = { ...@@ -2468,7 +2468,7 @@ struct proto tcp_prot = {
.obj_size = sizeof(struct tcp_sock), .obj_size = sizeof(struct tcp_sock),
.twsk_prot = &tcp_timewait_sock_ops, .twsk_prot = &tcp_timewait_sock_ops,
.rsk_prot = &tcp_request_sock_ops, .rsk_prot = &tcp_request_sock_ops,
.hashinfo = &tcp_hashinfo, .h.hashinfo = &tcp_hashinfo,
#ifdef CONFIG_COMPAT #ifdef CONFIG_COMPAT
.compat_setsockopt = compat_tcp_setsockopt, .compat_setsockopt = compat_tcp_setsockopt,
.compat_getsockopt = compat_tcp_getsockopt, .compat_getsockopt = compat_tcp_getsockopt,
......
...@@ -24,7 +24,7 @@ ...@@ -24,7 +24,7 @@
void __inet6_hash(struct sock *sk) void __inet6_hash(struct sock *sk)
{ {
struct inet_hashinfo *hashinfo = sk->sk_prot->hashinfo; struct inet_hashinfo *hashinfo = sk->sk_prot->h.hashinfo;
struct hlist_head *list; struct hlist_head *list;
rwlock_t *lock; rwlock_t *lock;
......
...@@ -2172,7 +2172,7 @@ struct proto tcpv6_prot = { ...@@ -2172,7 +2172,7 @@ struct proto tcpv6_prot = {
.obj_size = sizeof(struct tcp6_sock), .obj_size = sizeof(struct tcp6_sock),
.twsk_prot = &tcp6_timewait_sock_ops, .twsk_prot = &tcp6_timewait_sock_ops,
.rsk_prot = &tcp6_request_sock_ops, .rsk_prot = &tcp6_request_sock_ops,
.hashinfo = &tcp_hashinfo, .h.hashinfo = &tcp_hashinfo,
#ifdef CONFIG_COMPAT #ifdef CONFIG_COMPAT
.compat_setsockopt = compat_tcp_setsockopt, .compat_setsockopt = compat_tcp_setsockopt,
.compat_getsockopt = compat_tcp_getsockopt, .compat_getsockopt = compat_tcp_getsockopt,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment