Commit 3a17fefe authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen

scsi: ufs: Follow the kernel-doc syntax for documenting return values

Use 'Return:' to document the return value instead of 'Returns' as required
by the kernel-doc documentation.
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230727194457.3152309-2-bvanassche@acm.orgSigned-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 2903265e
...@@ -105,7 +105,7 @@ EXPORT_SYMBOL_GPL(ufshcd_mcq_config_mac); ...@@ -105,7 +105,7 @@ EXPORT_SYMBOL_GPL(ufshcd_mcq_config_mac);
* @hba: per adapter instance * @hba: per adapter instance
* @req: pointer to the request to be issued * @req: pointer to the request to be issued
* *
* Returns the hardware queue instance on which the request would * Return: the hardware queue instance on which the request would
* be queued. * be queued.
*/ */
struct ufs_hw_queue *ufshcd_mcq_req_to_hwq(struct ufs_hba *hba, struct ufs_hw_queue *ufshcd_mcq_req_to_hwq(struct ufs_hba *hba,
...@@ -121,7 +121,7 @@ struct ufs_hw_queue *ufshcd_mcq_req_to_hwq(struct ufs_hba *hba, ...@@ -121,7 +121,7 @@ struct ufs_hw_queue *ufshcd_mcq_req_to_hwq(struct ufs_hba *hba,
* ufshcd_mcq_decide_queue_depth - decide the queue depth * ufshcd_mcq_decide_queue_depth - decide the queue depth
* @hba: per adapter instance * @hba: per adapter instance
* *
* Returns queue-depth on success, non-zero on error * Return: queue-depth on success, non-zero on error
* *
* MAC - Max. Active Command of the Host Controller (HC) * MAC - Max. Active Command of the Host Controller (HC)
* HC wouldn't send more than this commands to the device. * HC wouldn't send more than this commands to the device.
...@@ -493,7 +493,7 @@ static int ufshcd_mcq_sq_start(struct ufs_hba *hba, struct ufs_hw_queue *hwq) ...@@ -493,7 +493,7 @@ static int ufshcd_mcq_sq_start(struct ufs_hba *hba, struct ufs_hw_queue *hwq)
* @hba: per adapter instance. * @hba: per adapter instance.
* @task_tag: The command's task tag. * @task_tag: The command's task tag.
* *
* Returns 0 for success; error code otherwise. * Return: 0 for success; error code otherwise.
*/ */
int ufshcd_mcq_sq_cleanup(struct ufs_hba *hba, int task_tag) int ufshcd_mcq_sq_cleanup(struct ufs_hba *hba, int task_tag)
{ {
...@@ -575,7 +575,7 @@ static void ufshcd_mcq_nullify_sqe(struct utp_transfer_req_desc *utrd) ...@@ -575,7 +575,7 @@ static void ufshcd_mcq_nullify_sqe(struct utp_transfer_req_desc *utrd)
* @hwq: Hardware Queue to be searched. * @hwq: Hardware Queue to be searched.
* @task_tag: The command's task tag. * @task_tag: The command's task tag.
* *
* Returns true if the SQE containing the command is present in the SQ * Return: true if the SQE containing the command is present in the SQ
* (not fetched by the controller); returns false if the SQE is not in the SQ. * (not fetched by the controller); returns false if the SQE is not in the SQ.
*/ */
static bool ufshcd_mcq_sqe_search(struct ufs_hba *hba, static bool ufshcd_mcq_sqe_search(struct ufs_hba *hba,
...@@ -624,7 +624,7 @@ static bool ufshcd_mcq_sqe_search(struct ufs_hba *hba, ...@@ -624,7 +624,7 @@ static bool ufshcd_mcq_sqe_search(struct ufs_hba *hba,
* ufshcd_mcq_abort - Abort the command in MCQ. * ufshcd_mcq_abort - Abort the command in MCQ.
* @cmd: The command to be aborted. * @cmd: The command to be aborted.
* *
* Returns SUCCESS or FAILED error codes * Return: SUCCESS or FAILED error codes
*/ */
int ufshcd_mcq_abort(struct scsi_cmnd *cmd) int ufshcd_mcq_abort(struct scsi_cmnd *cmd)
{ {
......
...@@ -294,7 +294,7 @@ extern const struct ufs_pm_lvl_states ufs_pm_lvl_states[]; ...@@ -294,7 +294,7 @@ extern const struct ufs_pm_lvl_states ufs_pm_lvl_states[];
* ufshcd_scsi_to_upiu_lun - maps scsi LUN to UPIU LUN * ufshcd_scsi_to_upiu_lun - maps scsi LUN to UPIU LUN
* @scsi_lun: scsi LUN id * @scsi_lun: scsi LUN id
* *
* Returns UPIU LUN id * Return: UPIU LUN id
*/ */
static inline u8 ufshcd_scsi_to_upiu_lun(unsigned int scsi_lun) static inline u8 ufshcd_scsi_to_upiu_lun(unsigned int scsi_lun)
{ {
......
This diff is collapsed.
...@@ -105,7 +105,7 @@ static void cdns_ufs_set_l4_attr(struct ufs_hba *hba) ...@@ -105,7 +105,7 @@ static void cdns_ufs_set_l4_attr(struct ufs_hba *hba)
* Sets HCLKDIV register value based on the core_clk * Sets HCLKDIV register value based on the core_clk
* @hba: host controller instance * @hba: host controller instance
* *
* Return zero for success and non-zero for failure * Return: zero for success and non-zero for failure.
*/ */
static int cdns_ufs_set_hclkdiv(struct ufs_hba *hba) static int cdns_ufs_set_hclkdiv(struct ufs_hba *hba)
{ {
...@@ -148,7 +148,7 @@ static int cdns_ufs_set_hclkdiv(struct ufs_hba *hba) ...@@ -148,7 +148,7 @@ static int cdns_ufs_set_hclkdiv(struct ufs_hba *hba)
* @hba: host controller instance * @hba: host controller instance
* @status: notify stage (pre, post change) * @status: notify stage (pre, post change)
* *
* Return zero for success and non-zero for failure * Return: zero for success and non-zero for failure.
*/ */
static int cdns_ufs_hce_enable_notify(struct ufs_hba *hba, static int cdns_ufs_hce_enable_notify(struct ufs_hba *hba,
enum ufs_notify_change_status status) enum ufs_notify_change_status status)
...@@ -182,7 +182,7 @@ static void cdns_ufs_hibern8_notify(struct ufs_hba *hba, enum uic_cmd_dme cmd, ...@@ -182,7 +182,7 @@ static void cdns_ufs_hibern8_notify(struct ufs_hba *hba, enum uic_cmd_dme cmd,
* @hba: host controller instance * @hba: host controller instance
* @status: notify stage (pre, post change) * @status: notify stage (pre, post change)
* *
* Return zero for success and non-zero for failure * Return: zero for success and non-zero for failure.
*/ */
static int cdns_ufs_link_startup_notify(struct ufs_hba *hba, static int cdns_ufs_link_startup_notify(struct ufs_hba *hba,
enum ufs_notify_change_status status) enum ufs_notify_change_status status)
...@@ -212,7 +212,7 @@ static int cdns_ufs_link_startup_notify(struct ufs_hba *hba, ...@@ -212,7 +212,7 @@ static int cdns_ufs_link_startup_notify(struct ufs_hba *hba,
* cdns_ufs_init - performs additional ufs initialization * cdns_ufs_init - performs additional ufs initialization
* @hba: host controller instance * @hba: host controller instance
* *
* Returns status of initialization * Return: status of initialization.
*/ */
static int cdns_ufs_init(struct ufs_hba *hba) static int cdns_ufs_init(struct ufs_hba *hba)
{ {
...@@ -284,7 +284,7 @@ MODULE_DEVICE_TABLE(of, cdns_ufs_of_match); ...@@ -284,7 +284,7 @@ MODULE_DEVICE_TABLE(of, cdns_ufs_of_match);
* cdns_ufs_pltfrm_probe - probe routine of the driver * cdns_ufs_pltfrm_probe - probe routine of the driver
* @pdev: pointer to platform device handle * @pdev: pointer to platform device handle
* *
* Return zero for success and non-zero for failure * Return: zero for success and non-zero for failure.
*/ */
static int cdns_ufs_pltfrm_probe(struct platform_device *pdev) static int cdns_ufs_pltfrm_probe(struct platform_device *pdev)
{ {
......
...@@ -51,7 +51,7 @@ static void tc_dwc_g210_pci_remove(struct pci_dev *pdev) ...@@ -51,7 +51,7 @@ static void tc_dwc_g210_pci_remove(struct pci_dev *pdev)
* @pdev: pointer to PCI device handle * @pdev: pointer to PCI device handle
* @id: PCI device id * @id: PCI device id
* *
* Returns 0 on success, non-zero value on failure * Return: 0 on success, non-zero value on failure.
*/ */
static int static int
tc_dwc_g210_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) tc_dwc_g210_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
......
...@@ -21,7 +21,7 @@ ...@@ -21,7 +21,7 @@
* This function configures Synopsys TC specific atributes (40-bit RMMI) * This function configures Synopsys TC specific atributes (40-bit RMMI)
* @hba: Pointer to drivers structure * @hba: Pointer to drivers structure
* *
* Returns 0 on success or non-zero value on failure * Return: 0 on success or non-zero value on failure.
*/ */
static int tc_dwc_g210_setup_40bit_rmmi(struct ufs_hba *hba) static int tc_dwc_g210_setup_40bit_rmmi(struct ufs_hba *hba)
{ {
...@@ -85,7 +85,7 @@ static int tc_dwc_g210_setup_40bit_rmmi(struct ufs_hba *hba) ...@@ -85,7 +85,7 @@ static int tc_dwc_g210_setup_40bit_rmmi(struct ufs_hba *hba)
* This function configures Synopsys TC 20-bit RMMI Lane 0 * This function configures Synopsys TC 20-bit RMMI Lane 0
* @hba: Pointer to drivers structure * @hba: Pointer to drivers structure
* *
* Returns 0 on success or non-zero value on failure * Return: 0 on success or non-zero value on failure.
*/ */
static int tc_dwc_g210_setup_20bit_rmmi_lane0(struct ufs_hba *hba) static int tc_dwc_g210_setup_20bit_rmmi_lane0(struct ufs_hba *hba)
{ {
...@@ -138,7 +138,7 @@ static int tc_dwc_g210_setup_20bit_rmmi_lane0(struct ufs_hba *hba) ...@@ -138,7 +138,7 @@ static int tc_dwc_g210_setup_20bit_rmmi_lane0(struct ufs_hba *hba)
* This function configures Synopsys TC 20-bit RMMI Lane 1 * This function configures Synopsys TC 20-bit RMMI Lane 1
* @hba: Pointer to drivers structure * @hba: Pointer to drivers structure
* *
* Returns 0 on success or non-zero value on failure * Return: 0 on success or non-zero value on failure.
*/ */
static int tc_dwc_g210_setup_20bit_rmmi_lane1(struct ufs_hba *hba) static int tc_dwc_g210_setup_20bit_rmmi_lane1(struct ufs_hba *hba)
{ {
...@@ -215,7 +215,7 @@ static int tc_dwc_g210_setup_20bit_rmmi_lane1(struct ufs_hba *hba) ...@@ -215,7 +215,7 @@ static int tc_dwc_g210_setup_20bit_rmmi_lane1(struct ufs_hba *hba)
* This function configures Synopsys TC specific atributes (20-bit RMMI) * This function configures Synopsys TC specific atributes (20-bit RMMI)
* @hba: Pointer to drivers structure * @hba: Pointer to drivers structure
* *
* Returns 0 on success or non-zero value on failure * Return: 0 on success or non-zero value on failure.
*/ */
static int tc_dwc_g210_setup_20bit_rmmi(struct ufs_hba *hba) static int tc_dwc_g210_setup_20bit_rmmi(struct ufs_hba *hba)
{ {
...@@ -256,7 +256,7 @@ static int tc_dwc_g210_setup_20bit_rmmi(struct ufs_hba *hba) ...@@ -256,7 +256,7 @@ static int tc_dwc_g210_setup_20bit_rmmi(struct ufs_hba *hba)
* *
* @hba: Pointer to drivers structure * @hba: Pointer to drivers structure
* *
* Returns 0 on success non-zero value on failure * Return: 0 on success non-zero value on failure.
*/ */
int tc_dwc_g210_config_40_bit(struct ufs_hba *hba) int tc_dwc_g210_config_40_bit(struct ufs_hba *hba)
{ {
...@@ -288,7 +288,7 @@ EXPORT_SYMBOL(tc_dwc_g210_config_40_bit); ...@@ -288,7 +288,7 @@ EXPORT_SYMBOL(tc_dwc_g210_config_40_bit);
* *
* @hba: Pointer to drivers structure * @hba: Pointer to drivers structure
* *
* Returns 0 on success non-zero value on failure * Return: 0 on success non-zero value on failure.
*/ */
int tc_dwc_g210_config_20_bit(struct ufs_hba *hba) int tc_dwc_g210_config_20_bit(struct ufs_hba *hba)
{ {
......
...@@ -666,7 +666,7 @@ static void ufs_mtk_pwr_ctrl(struct ufs_hba *hba, bool on) ...@@ -666,7 +666,7 @@ static void ufs_mtk_pwr_ctrl(struct ufs_hba *hba, bool on)
* @on: If true, enable clocks else disable them. * @on: If true, enable clocks else disable them.
* @status: PRE_CHANGE or POST_CHANGE notify * @status: PRE_CHANGE or POST_CHANGE notify
* *
* Returns 0 on success, non-zero on failure. * Return: 0 on success, non-zero on failure.
*/ */
static int ufs_mtk_setup_clocks(struct ufs_hba *hba, bool on, static int ufs_mtk_setup_clocks(struct ufs_hba *hba, bool on,
enum ufs_notify_change_status status) enum ufs_notify_change_status status)
...@@ -885,7 +885,7 @@ static void ufs_mtk_init_mcq_irq(struct ufs_hba *hba) ...@@ -885,7 +885,7 @@ static void ufs_mtk_init_mcq_irq(struct ufs_hba *hba)
* Binds PHY with controller and powers up PHY enabling clocks * Binds PHY with controller and powers up PHY enabling clocks
* and regulators. * and regulators.
* *
* Returns -EPROBE_DEFER if binding fails, returns negative error * Return: -EPROBE_DEFER if binding fails, returns negative error
* on phy power up failure and returns zero on success. * on phy power up failure and returns zero on success.
*/ */
static int ufs_mtk_init(struct ufs_hba *hba) static int ufs_mtk_init(struct ufs_hba *hba)
...@@ -1696,7 +1696,7 @@ static const struct ufs_hba_variant_ops ufs_hba_mtk_vops = { ...@@ -1696,7 +1696,7 @@ static const struct ufs_hba_variant_ops ufs_hba_mtk_vops = {
* ufs_mtk_probe - probe routine of the driver * ufs_mtk_probe - probe routine of the driver
* @pdev: pointer to Platform device handle * @pdev: pointer to Platform device handle
* *
* Return zero for success and non-zero for failure * Return: zero for success and non-zero for failure.
*/ */
static int ufs_mtk_probe(struct platform_device *pdev) static int ufs_mtk_probe(struct platform_device *pdev)
{ {
......
...@@ -485,7 +485,7 @@ static int ufs_qcom_hce_enable_notify(struct ufs_hba *hba, ...@@ -485,7 +485,7 @@ static int ufs_qcom_hce_enable_notify(struct ufs_hba *hba,
} }
/* /*
* Returns zero for success and non-zero in case of a failure * Return: zero for success and non-zero in case of a failure.
*/ */
static int ufs_qcom_cfg_timers(struct ufs_hba *hba, u32 gear, static int ufs_qcom_cfg_timers(struct ufs_hba *hba, u32 gear,
u32 hs, u32 rate, bool update_link_startup_timer) u32 hs, u32 rate, bool update_link_startup_timer)
...@@ -964,7 +964,7 @@ static void ufs_qcom_set_caps(struct ufs_hba *hba) ...@@ -964,7 +964,7 @@ static void ufs_qcom_set_caps(struct ufs_hba *hba)
* @on: If true, enable clocks else disable them. * @on: If true, enable clocks else disable them.
* @status: PRE_CHANGE or POST_CHANGE notify * @status: PRE_CHANGE or POST_CHANGE notify
* *
* Returns 0 on success, non-zero on failure. * Return: 0 on success, non-zero on failure.
*/ */
static int ufs_qcom_setup_clocks(struct ufs_hba *hba, bool on, static int ufs_qcom_setup_clocks(struct ufs_hba *hba, bool on,
enum ufs_notify_change_status status) enum ufs_notify_change_status status)
...@@ -1038,7 +1038,7 @@ static const struct reset_control_ops ufs_qcom_reset_ops = { ...@@ -1038,7 +1038,7 @@ static const struct reset_control_ops ufs_qcom_reset_ops = {
* Binds PHY with controller and powers up PHY enabling clocks * Binds PHY with controller and powers up PHY enabling clocks
* and regulators. * and regulators.
* *
* Returns -EPROBE_DEFER if binding fails, returns negative error * Return: -EPROBE_DEFER if binding fails, returns negative error
* on phy power up failure and returns zero on success. * on phy power up failure and returns zero on success.
*/ */
static int ufs_qcom_init(struct ufs_hba *hba) static int ufs_qcom_init(struct ufs_hba *hba)
...@@ -1756,7 +1756,7 @@ static const struct ufs_hba_variant_ops ufs_hba_qcom_vops = { ...@@ -1756,7 +1756,7 @@ static const struct ufs_hba_variant_ops ufs_hba_qcom_vops = {
* ufs_qcom_probe - probe routine of the driver * ufs_qcom_probe - probe routine of the driver
* @pdev: pointer to Platform device handle * @pdev: pointer to Platform device handle
* *
* Return zero for success and non-zero for failure * Return: zero for success and non-zero for failure.
*/ */
static int ufs_qcom_probe(struct platform_device *pdev) static int ufs_qcom_probe(struct platform_device *pdev)
{ {
......
...@@ -51,7 +51,7 @@ static void ufshcd_dwc_program_clk_div(struct ufs_hba *hba, u32 divider_val) ...@@ -51,7 +51,7 @@ static void ufshcd_dwc_program_clk_div(struct ufs_hba *hba, u32 divider_val)
* Check if link is up * Check if link is up
* @hba: private structure pointer * @hba: private structure pointer
* *
* Returns 0 on success, non-zero value on failure * Return: 0 on success, non-zero value on failure.
*/ */
static int ufshcd_dwc_link_is_up(struct ufs_hba *hba) static int ufshcd_dwc_link_is_up(struct ufs_hba *hba)
{ {
...@@ -78,7 +78,7 @@ static int ufshcd_dwc_link_is_up(struct ufs_hba *hba) ...@@ -78,7 +78,7 @@ static int ufshcd_dwc_link_is_up(struct ufs_hba *hba)
* *
* @hba: pointer to drivers private data * @hba: pointer to drivers private data
* *
* Returns 0 on success non-zero value on failure * Return: 0 on success non-zero value on failure.
*/ */
static int ufshcd_dwc_connection_setup(struct ufs_hba *hba) static int ufshcd_dwc_connection_setup(struct ufs_hba *hba)
{ {
...@@ -112,7 +112,7 @@ static int ufshcd_dwc_connection_setup(struct ufs_hba *hba) ...@@ -112,7 +112,7 @@ static int ufshcd_dwc_connection_setup(struct ufs_hba *hba)
* @hba: private structure pointer * @hba: private structure pointer
* @status: Callback notify status * @status: Callback notify status
* *
* Returns 0 on success, non-zero value on failure * Return: 0 on success, non-zero value on failure.
*/ */
int ufshcd_dwc_link_startup_notify(struct ufs_hba *hba, int ufshcd_dwc_link_startup_notify(struct ufs_hba *hba,
enum ufs_notify_change_status status) enum ufs_notify_change_status status)
......
...@@ -524,7 +524,7 @@ static void ufshcd_pci_remove(struct pci_dev *pdev) ...@@ -524,7 +524,7 @@ static void ufshcd_pci_remove(struct pci_dev *pdev)
* @pdev: pointer to PCI device handle * @pdev: pointer to PCI device handle
* @id: PCI device id * @id: PCI device id
* *
* Returns 0 on success, non-zero value on failure * Return: 0 on success, non-zero value on failure.
*/ */
static int static int
ufshcd_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) ufshcd_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
......
...@@ -212,7 +212,7 @@ static void ufshcd_init_lanes_per_dir(struct ufs_hba *hba) ...@@ -212,7 +212,7 @@ static void ufshcd_init_lanes_per_dir(struct ufs_hba *hba)
* @dev_max: pointer to device attributes * @dev_max: pointer to device attributes
* @agreed_pwr: returned agreed attributes * @agreed_pwr: returned agreed attributes
* *
* Returns 0 on success, non-zero value on failure * Return: 0 on success, non-zero value on failure.
*/ */
int ufshcd_get_pwr_dev_param(const struct ufs_dev_params *pltfrm_param, int ufshcd_get_pwr_dev_param(const struct ufs_dev_params *pltfrm_param,
const struct ufs_pa_layer_attr *dev_max, const struct ufs_pa_layer_attr *dev_max,
...@@ -326,7 +326,7 @@ EXPORT_SYMBOL_GPL(ufshcd_init_pwr_dev_param); ...@@ -326,7 +326,7 @@ EXPORT_SYMBOL_GPL(ufshcd_init_pwr_dev_param);
* @pdev: pointer to Platform device handle * @pdev: pointer to Platform device handle
* @vops: pointer to variant ops * @vops: pointer to variant ops
* *
* Returns 0 on success, non-zero value on failure * Return: 0 on success, non-zero value on failure.
*/ */
int ufshcd_pltfrm_init(struct platform_device *pdev, int ufshcd_pltfrm_init(struct platform_device *pdev,
const struct ufs_hba_variant_ops *vops) const struct ufs_hba_variant_ops *vops)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment